Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@ztzg
Copy link
Contributor

@ztzg ztzg commented Feb 20, 2011

Hi,

Without these, ./configure --enable-static --disable-shared … && make fails on Mac OS X (but I believe the second fix is not OS-specific).

I cargo-culted the solutions from other Makefile.ams.

Cheers, -D

@kumpera
Copy link
Contributor

kumpera commented May 12, 2011

Looks good, please rebase on top of current head and I'll apply it.

@alexrp
Copy link
Contributor

alexrp commented Sep 4, 2012

Is this still relevant today? If so, ping @ztzg.

@kumpera
Copy link
Contributor

kumpera commented Sep 4, 2012

I bet --enable-static still fails on master. Someone should take over this.

@ztzg
Copy link
Contributor Author

ztzg commented Sep 5, 2012

Hi Alex, Rodrigo,

I had a quick look, and I can confirm that --disable-shared still fails on master.

The patch has to be updated, though. I managed to compile it locally with the following (quick & dirty) changes:

https://github.com/ztzg/mono/commits/darwin-static-build-fixes-rfc

but haven't updated the pull request because the fix is not complete.

In addition to the static vs. shared option, various configurations have to be accounted for:

  • INCLUDED_LIBGC vs. system libgc;
  • SUPPORT_SGEN vs. SUPPORT_BOEHM;
  • JIT_SUPPORTED vs. no JIT.

and I would prefer to avoid copying a huge amount of boilerplate in each Makefile.am; would you have suggestions on how to properly handle this with the current build system?

@alexrp
Copy link
Contributor

alexrp commented Sep 5, 2012

For what it's worth, I don't think you should bother with the !JIT_SUPPORTED case. It's probably bitrotted to hell anyway.

…ared

There is no 'libmono-$(API_VER).la' when the shared runtime is
disabled; use 'libmini-static.la' instead.

Solution stolen/adapted from mono/mini/Makefile.am.

Commit contributed under the MIT/X11 license.
@ztzg
Copy link
Contributor Author

ztzg commented Sep 10, 2012

I have cleaned my recent "RFC" commit as much as I could, but there is still some duplication. As suggested by Alex, I did not pay attention to the !JIT_SUPPORTED case. The following combinations have been tested:

  • Linux, --disable-shared;
  • Mac OS X, --disable-shared;
  • Linux, --disable-static;
  • Mac OS X, --disable-static.

Feel free to merge and/or suggest other improvements, as this solution is far from perfect.

kumpera added a commit that referenced this pull request Sep 10, 2012
@kumpera kumpera merged commit e2ba6bf into mono:master Sep 10, 2012
@kumpera
Copy link
Contributor

kumpera commented Sep 10, 2012

Thanks for the patch!

luhenry added a commit to luhenry/mono that referenced this pull request May 25, 2018
Commit list for mono/corefx:

* mono/corefx@4dc1df47d5 Fix for GCC < 4.8 compilers (mono#62)
* mono/corefx@427aa8cca1 Merge pull request mono#61 from mono/corefx-pal-random
* mono/corefx@59b723b94a Add Mono-specific conditionals to HashCode.cs.
* mono/corefx@8939784230 Convert pal_random to C for integration with Mono

Diff: mono/corefx@26b71b5...4dc1df4
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants