-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Darwin/static build fixes #61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks good, please rebase on top of current head and I'll apply it. |
|
Is this still relevant today? If so, ping @ztzg. |
|
I bet --enable-static still fails on master. Someone should take over this. |
|
Hi Alex, Rodrigo, I had a quick look, and I can confirm that The patch has to be updated, though. I managed to compile it locally with the following (quick & dirty) changes: https://github.com/ztzg/mono/commits/darwin-static-build-fixes-rfc but haven't updated the pull request because the fix is not complete. In addition to the static vs. shared option, various configurations have to be accounted for:
and I would prefer to avoid copying a huge amount of boilerplate in each |
|
For what it's worth, I don't think you should bother with the |
…ared There is no 'libmono-$(API_VER).la' when the shared runtime is disabled; use 'libmini-static.la' instead. Solution stolen/adapted from mono/mini/Makefile.am. Commit contributed under the MIT/X11 license.
|
I have cleaned my recent "RFC" commit as much as I could, but there is still some duplication. As suggested by Alex, I did not pay attention to the
Feel free to merge and/or suggest other improvements, as this solution is far from perfect. |
|
Thanks for the patch! |
Commit list for mono/corefx: * mono/corefx@4dc1df47d5 Fix for GCC < 4.8 compilers (mono#62) * mono/corefx@427aa8cca1 Merge pull request mono#61 from mono/corefx-pal-random * mono/corefx@59b723b94a Add Mono-specific conditionals to HashCode.cs. * mono/corefx@8939784230 Convert pal_random to C for integration with Mono Diff: mono/corefx@26b71b5...4dc1df4
Darwin/static build fixes Commit migrated from mono/mono@e2ba6bf
Hi,
Without these,
./configure --enable-static --disable-shared … && makefails on Mac OS X (but I believe the second fix is not OS-specific).I cargo-culted the solutions from other
Makefile.ams.Cheers, -D