Fix a couple bugs in TaskScheduler and Task #74
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
that scheduler is ignored if it is in a thread owned by another scheduler. Tasks should not be locked to the scheduler that owns the calling thread. Fix bug where TryExecuteTask does not actually try to execute the task. Instead, TryExecuteTaskInline is called, which is abstract. The TpScheduler implementation, the default, then calls the internal method Task.Execute which then actually executes the task. The problem with this is that only 3rd party schedulers, can't actually execute a task, thus making extending TaskScheduler impossible. (Unless they use some serious Mono specific reflection hacks as I am now.)
Contributor
Author
|
Would appreciate a backport to 2.10 and monodroid please :) |
Contributor
|
Looks good, merged in master but I'm waiting on wrench to push back to 2-10 and monodroid. Thanks! |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
submitted under MIT license.
I did NOT run tests, as for some reason my Mono checkout just SIGSEGV's quite beautifully when calling make run-test.