Task/Future bugs #75
Closed
Task/Future bugs #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f Future is in faulted state/raise the exception
…askCompletionSource can use overloaded constructors and it will pass null in function argument)
Contributor
|
Applied these patches to 2-10 and master. Jeremie, are you OK with them? |
Contributor
|
Heya, just as post-merge advice, please run the test suite before submitting your pull request (in this case on Task) cause one of your commit introduced a regression |
richard-fine
referenced
this pull request
in richard-fine/mono
Aug 12, 2013
…-staging [Tizen] Update to SDK 2.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ported parts of mono TPL implementation to Silverlight to get Task type and I found these bugs.
The null condition bugs happens when using TaskCompletionSource - Wait() never gets called for task completion source task since function is null so it will return null. Constructors will wrap nulls with lambdas so function member will not be null and lambda will try to call null reference.
(btw. sorry for the last two commits i didn't realize code was using tabs :) )