[Tailcall] Cleanup is_supported_tail_call, put more logic in it, and be sure not to tailcall_mem_base if not supported (i.e. virtual_ not just CALLVIRT) #7608
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i.e. not if virtual_, besides CALLVIRT -- they are not quite the same.
vargaz
approved these changes
Mar 14, 2018
luhenry
reviewed
Mar 15, 2018
| g_assertf (call_opcode == CEE_CALL || call_opcode == CEE_CALLVIRT || call_opcode == CEE_CALLI, "%s (%d)", mono_opcode_name (call_opcode), (int)call_opcode); | ||
|
|
||
| if ( (fsig->hasthis && cmethod->klass->valuetype) // This might point to the current method's stack. Emit range check? | ||
| || (cmethod->flags & METHOD_ATTRIBUTE_PINVOKE_IMPL) |
Contributor
There was a problem hiding this comment.
This is a much harder to read than the previous code, and it's shuffling around the code for no benefits.
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…be sure not to tailcall_mem_base if not supported (i.e. virtual_ not just CALLVIRT) (mono/mono#7608) * [Tailcall] Cleanup is_supported_tail_call to use language-base short circuit. * [Tailcall] Move more of the logic into is_supported_tail_call. * [Tailcall] Be sure not to use TAILCALL_MEM_BASE if not supported. i.e. not if virtual_, besides CALLVIRT -- they are not quite the same. Commit migrated from mono/mono@a856f8d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Tailcall] Cleanup is_supported_tail_call, put more logic in it, and be sure not to tailcall_mem_base if not supported (i.e. virtual_ not just CALLVIRT)