[sre-save] Remove type_token assignment in mono_image_fill_export_table #7803
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 9725d50 we added the `g_error`, that should fire if the MonoClass:type_token and the TypeBuilder token ever disagree. As a result, this assignment is strictly redundant.
19 tasks
luhenry
approved these changes
Mar 24, 2018
Member
Author
|
@monojenkins build Linux x64 |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…le (mono/mono#7803) In mono/mono@9725d50 we added the `g_error`, that should fire if the MonoClass:type_token and the TypeBuilder token ever disagree. As a result, this assignment is strictly redundant. Commit migrated from mono/mono@2ce121a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 9725d50 we added the
g_error, that shouldfire if the
MonoClass:type_tokenand theTypeBuildertoken ever disagree. As aresult, this assignment is strictly redundant.