Define mono_class_init_ready and MIN and MAX readiness levels #7857
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We already have the idea of a MonoClass being partially initialized. With this commit, we explicitly introduce the idea of a /readiness level/. With mono_class_init_ready (k, r) we can ask that k be prepared to readiness level r. The readiness levels range between MONO_CLASS_READY_MIN (aka MONO_CLASS_READY_BAREBONES) which is the state in which a MonoClass* is first created (that is, mono_class_init_ready (k, MONO_CLASS_READY_BAREBONES) does no additional initialization), to MONO_CLASS_READY_MAX (aka MONO_CLASS_READY_INSTANTIATE) which means that the class is fully loaded and we can create per-domain vtables for the class and ultimately MonoObjects instances of the class. In this PR we just re-implement mono_class_init (k) in terms of mono_class_init_ready (k, MONO_CLASS_READY_MAX) but not any of the callers of mono_class_init().
…_CLASS_READY_MAX) Mark mono_class_init external only. Each of these call sites should be revisited to see if it is possible to lower the readiness level based on which portion of the MonoClass the call site is going to use.
luhenry
reviewed
Mar 27, 2018
| case MONO_CLASS_READY_INSTANTIATE: | ||
| break; /* continue with initialization */ | ||
| default: | ||
| g_assert_not_reached (); |
Contributor
There was a problem hiding this comment.
a g_error with the value passed would help debugging.
Contributor
|
LGTM, should this cover the many lazy init steps in the setup functions? One thing, I believe the comment in MONO_CLASS_READY_INSTANTIATE is incorrect as mono_class_init AFAICT doesn't do vtable setup. |
Member
Author
Contributor
|
Since this is older, I'm closing. Please see the old pull request policy for more info. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FOR REFERENCE ONLY
Please comment on the RFC and design discussion