[ThreadPool] Allow heavier initialization when using --server flag #725
Conversation
|
We're not going to expose a global variable in the API. This is a no go. A mono_config_set_server_mode function should be added instead. |
|
@kumpera thanks for the review. I guess you also mean that I should add a getter "mono_config_get_server_mode" to be used in threadpool.c? If yes, then this raises the question: is desktop mode a non-server mode? In case neither --desktop nor --server flags are provided, is that a different 3rd mode? If not, then either --desktop or --server should be a default? |
|
I guess we're down to 3 modes: mobile, desktop, server. It's fine if we have 2 modes leading to the same execution decision. |
|
Ok, so I guess I'll assume that mobile mode will be the one that is enabled when no --desktop or --server flag is passed. I'll also assume you're fine with "mono_config_get_server_mode" and I'll update the PR. Thanks! |
Create on demand up to min_threads to avoid startup penalty, avoiding throttling of threadpool worker thread creation (for now, using a --server flag) at initialization. When throttling happens, operations such as parallel https requests were slowed down significantly due to all of the threads created in order to complete the SSL operations. Based on @kamalaboulhosn's patch (https://github.com/mono/mono/pull/640/files)
|
Commit amended, PR updated. |
[ThreadPool] Allow heavier initialization when using --server flag
[ThreadPool] Allow heavier initialization when using --server flag Commit migrated from mono/mono@e86837b
…ing-il2cpp-debugger-vtsu-tweaks IL2CPP Debugger VSTU stepping tweaks
Create on demand up to min_threads to avoid startup penalty, avoiding
throttling of threadpool worker thread creation (for now, using
a --server flag) at initialization.
When throttling happens, operations such as parallel https requests were
slowed down significantly due to all of the threads created in order
to complete the SSL operations.
Based on @kamalaboulhosn's pull request (#640), addressing Miguel's comment.
(Tried putting the gboolean variable in mini.c/mini.h, but this didn't work, as it would cause this compilation error:
make[3]: Entering directory
/home/knocte/Documents/Code/mymono/mono/metadata' CC libmonoruntime_la-mono-config.lo CC libmonoruntime_la-threadpool.lo In file included from threadpool.c:22:0: ../../mono/mini/mini.h:52:2: error: #error "The code in mini/ should not depend on these defines." make[3]: *** [libmonoruntime_la-threadpool.lo] Error 1 make[3]: Leaving directory/home/knocte/Documents/Code/mymono/mono/metadata'make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory
/home/knocte/Documents/Code/mymono/mono' make[1]: *** [all-recursive] Error 1 make[1]: Leaving directory/home/knocte/Documents/Code/mymono'make: *** [all] Error 2
So I moved it to mono-config.)