[runtime] Use MonoClass getters in a few small files #7254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently the way this field is used is to internally chain cached classes, so we need its address.
Member
Author
|
@monojenkins build Linux AArch64 |
luhenry
approved these changes
Feb 26, 2018
19 tasks
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
* [metadata] Fix m_classdef_get_next_class_cache getter to be byref Apparently the way this field is used is to internally chain cached classes, so we need its address. * [metadata] Use MonoClass getters in image.c * [metadata] Allow debug-helpers to access MonoClass fields directly. * [metadata] Use MonoClass getters in mono-error.c * [sgen] Use MonoClass getters in sgen-debug.c * [sgen] Use MonoClass getters in sgen-client-mono.h * [metadta] Use MonoClass getters in appdomain.c * [metadata] Use MonoClass getters in exceptions.c Commit migrated from mono/mono@8d37ddb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
m_classdef_get_next_class_cacheto be a byref getter since it's used to internally chain MonoClasses in a hash table.debug-helpers.cto accessMonoClassfields directly (rationale: all this stuff should be callable from a debugger session even in a checked mode with getter assertions enabled, once we have assertions in getters).sgen/sgen-debug.csgen/sgen-client-mono.hmetadata/image.cmetadata/appdomain.cmetadata/exceptions.cutils/mono-error.c#6925