[runtime] Use MonoClass getters in object.c #7351
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… class-init.c - Move mono_class_compute_gc_descriptor to class-init.c - Extract mono_class_setup_runtime_info from mono_class_create_runtime_vtable
19 tasks
kumpera
approved these changes
Mar 1, 2018
Contributor
kumpera
left a comment
There was a problem hiding this comment.
LGTM.
The comments are just random rants about existing code.
mono/metadata/class-init.c
Outdated
Contributor
There was a problem hiding this comment.
Ugg
Property bag setters don't need any locking.
mono/metadata/class-init.c
Outdated
Contributor
There was a problem hiding this comment.
Same here, locking shouldn't be needed, just a store barrier.
a8b84c8 to
2173040
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MonoClass:gc_descrandMonoClass:runtime_infoinitialization toclass-init.c:mono_class_compute_gc_descriptoralready existed,mono_class_setup_runtime_infois extracted frommono_class_create_runtime_vtable(it's the only part that mutates a MonoClass).object.c#6925