-
Notifications
You must be signed in to change notification settings - Fork 3.8k
[metadata] Use MonoClass getters in the rest of metadata/ #7354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I can feed this one bit by bit instead, if this is impossible to review... |
mono/metadata/class-accessors.c
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not a maintainable hack. We should eliminate those bitfields we need to address.
|
Test failures are related. I messed something up in here. |
68d91fe to
8c5074e
Compare
8c5074e to
7aeb95c
Compare
Fix warnings about missing prototypes for class-abi-details.h functions.
Compute the bit offset of MonoClass:countextbound
Used by sgen to fill nursery fragments before a collection
7aeb95c to
7f02a52
Compare
7f02a52 to
bb017f1
Compare
|
The |
…7354) Use `MonoClass` getters in the rest of the code in `mono/metadata/` 1. Add `mono_class_contextbound_bit_offset()` which returns the bit offset of `MonoClass:contextbound` which is needed by `remoting.c` 2. Add `mono_class_create_array_fill_type` which is used by sgen to write over unused nursery fragments. 3. Alllow `metadata-cross-helpers.c` to access `MonoClass` fields directly. Rationale: it needs to compute field offsets. 4. Everything else shouldn't have any functional changes. mono/mono#6925 --- * [metadata] Fix warnings in class-accessors.c Fix warnings about missing prototypes for class-abi-details.h functions. * [cominterop] Use MonoClass getters in cominterop.c * [loader] Use MonoClass getters in loader.c * [runtime] Use MonoClass getters in icall.c * [metadata] Add mono_class_contextbound_bit_offset() accessor Compute the bit offset of MonoClass:countextbound * [remoting] Use MonoClass getters for remoting.c * [boehm] Use MonoClass getters in boehm-gc.c * [callspec] Use MonoClass getters in callspec.c * [sre] Use MonoClass getters in dynamic-image.c * [w32] Use MonoClass getters in w32process.c * [debug] Use MonoClass getters in mono-debug.c * [runtime] Use MonoClass getters in method-builder.c * [runtime] Use MonoClass getters in security-manager.c * [coop] Use MonoClass getters in handle.c * [reflection] Use MonoClass getters in reflection.c * [sgen] Add mono_class_create_array_fill_type Used by sgen to fill nursery fragments before a collection * [sgen] Use MonoClass getters in sgen-mono.c and the GC bridges * [verify] Use MonoClass getters in the verifier * [sre] Use MonoClass getters in SRE * [custom_attr] Use MonoClass getters in custom-attrs.c * [metadata] Use MonoClass getters in gc.c * [security-core-clr] Use MonoClass getters in security-core-clr.c * [metadata] Use MonoClass getters in metadata.c * [metadata] Allow metadata-cross-helpers to access MonoClass fields * [coop handle] Use MonoClass getter in mono_handle_unbox_unsafe Commit migrated from mono/mono@8ba4947
Use
MonoClassgetters in the rest of the code inmono/metadata/mono_class_contextbound_bit_offset()which returns the bit offset ofMonoClass:contextboundwhich is needed byremoting.cmono_class_create_array_fill_typewhich is used by sgen to write over unused nursery fragments.metadata-cross-helpers.cto accessMonoClassfields directly. Rationale: it needs to compute field offsets.#6925