String.Join() calls List(IEnum) instead of looping #846
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
String.Join() instead of looping over IEnumerable<T> calls the constructor of List<T> accepting IEnumerable<T>. According to https://github.com/mono/mono/blob/master/mcs/class/corlib/System.Collections.Generic/List.cs#L67 it should be more efficient. Because JoinUnchecked() accepts string[] the option #2 is to call ToArray() extension method instead. https://github.com/mono/mono/blob/master/mcs/class/System.Core/System.Linq/Enumerable.cs#L2886
marek-safar
added a commit
that referenced
this pull request
Dec 24, 2013
String.Join() calls List(IEnum) instead of looping
AlexKnauth
pushed a commit
to AlexKnauth/mono
that referenced
this pull request
Nov 2, 2023
…ows-runtime-on-aot Fix COM and Windows Runtime support on UnityAot profile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
String.Join()instead of looping overIEnumerable<T>calls the constructor ofList<T>acceptingIEnumerable<T>.According to List.cs it should be more efficient.
Because
JoinUnchecked()acceptsstring[]the option #2 is to call ToArray() extension method