[btls] Fixes for windows. #8653
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
with existing build system, on Windows, with out-of-tree build. Not sure which factor does not like <> but "" should be ok.
…ows. 1. Make it be nothing. 1b. Use a .def file if there are actual exports. Really, .def files are a good idea. or 2. Use it consistently. This does #1.
Contributor
Author
|
@monojenkins build OS X i386 |
Contributor
Author
|
@monojenkins build Linux AArch64 |
directhex
approved these changes
May 10, 2018
Contributor
Author
|
@baulig needs to approve? |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
* [btls] Do not give gcc flags to msvc. * [btls] #include "btls-foo.h" instead of #include <btls-foo.h> to work with existing build system, on Windows, with out-of-tree build. Not sure which factor does not like <> but "" should be ok. * [blts] MONO_API is not used consistently and therefore errors on Windows. 1. Make it be nothing. 1b. Use a .def file if there are actual exports. Really, .def files are a good idea. or 2. Use it consistently. This does mono/mono#1. Commit migrated from mono/mono@baf58ed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.