[runtime] Add a signal handler for sigterm #8240

alexanderkyte · 2018-04-13T19:49:29Z

Fixes #8236

alexanderkyte · 2018-04-13T19:49:47Z

Fixes #8236

kumpera · 2018-04-13T20:17:33Z

What's the impact will that have on regular usage of ctrl+c from CLI usage?

migueldeicaza · 2018-04-13T20:24:04Z

I dont think we want to do this for SIGTERM, Rodrigo brings up a good case for why not.

vargaz · 2018-04-13T20:26:11Z

Yes, users expect ctlr+c to just terminate the app without doing anything else.

alexanderkyte · 2018-04-13T20:52:31Z

Ctrl+c sends a sigint, sigterm is sent by Force Quit and by POSIX kill .

alexanderkyte · 2018-04-13T20:54:13Z

SIGTERM is like SIGKILL, but the dying process is allowed resources to shut down cleanly. This was requested by VS4M for detecting force quit of applications due to hangs.

alexanderkyte · 2018-04-13T20:55:59Z

@monojenkins build pkg

alexrp · 2018-04-13T21:02:06Z

mono/mini/mini-posix.c

This should be documented in man/mono.1.

Use g_hasenv

lewurm · 2018-04-13T21:18:39Z

How about having another icall to enable this feature (instead of an env var). The MERP stuff is enabled by an icall too, so VSfM won't have to turn knobs in different places.

luhenry · 2018-04-13T22:07:57Z

mono/mini/mini-posix.c

Use g_hasenv

luhenry · 2018-04-13T23:41:23Z

@lewurm if we want to keep this feature for MERP only, then we will just enable it in the same icall as we enable MERP support, no need to create another one.

lewurm · 2018-04-17T08:10:39Z

mono/mini/mini-posix.c

this should be TARGET_OSX

luhenry · 2018-04-17T15:48:06Z

mono/mini/mini-posix.c

Why keeping the exit (1);?

Without an exit(1), you won't exit?
I think there's a minor API confusion here. mono_chain_signal only calls another signal handler if it's already been registered. There's no other sigterm handler, so if you put a print between the chain signal and the exit call, it fires.

Before chain signal And
After chain signal, before exit

Both fire.

This corresponds to the expected state in add_signal_handler, when previous_sa.sa_flags & SA_SIGINFO is false, and we have no already-registered signal handler to save.

For this to work the way you want it to, where removing exit doesn't make it not exit, you'd need to explicitly register the handler at the start of every run that makes mono exit when sent sigterm. POSIX just defaults to externally killing a process when there's no signal handler, that doesn't mean that there's automatically an observable signal handler for sigterm.

luhenry · 2018-04-18T02:38:28Z

It's broken on Android and Windows

luhenry · 2018-04-20T15:37:51Z

@monojenkins build Windows x64

luhenry · 2018-04-20T15:37:57Z

@monojenkins build Linux x64

luhenry · 2018-04-20T15:38:10Z

@monojenkins build Linux AArch64

luhenry · 2018-04-20T20:15:12Z

@monojenkins backport to 2018-02

luhenry · 2018-04-20T20:15:15Z

@monojenkins backport to 2018-04

monojenkins · 2018-04-20T20:16:57Z

@luhenry backporting to 2018-02 failed, the patch results in conflicts:

Applying: [runtime] Add a signal handler for sigterm
Applying: [runtime] Register sigtramp when merp handler enabled
Using index info to reconstruct a base tree...
M	mono/metadata/icall.c
M	mono/metadata/object-internals.h
M	mono/mini/mini-posix.c
M	mono/mini/mini-runtime.c
M	mono/mini/mini-runtime.h
Falling back to patching base and 3-way merge...
Auto-merging mono/mini/mini-runtime.h
CONFLICT (content): Merge conflict in mono/mini/mini-runtime.h
Auto-merging mono/mini/mini-runtime.c
Auto-merging mono/mini/mini-posix.c
Auto-merging mono/metadata/object-internals.h
Auto-merging mono/metadata/icall.c
error: Failed to merge in the changes.
Patch failed at 0002 [runtime] Register sigtramp when merp handler enabled

Please backport manually!

monojenkins · 2018-04-20T20:17:59Z

@luhenry backporting to 2018-04 failed, the patch results in conflicts:

Applying: [runtime] Add a signal handler for sigterm
Applying: [runtime] Register sigtramp when merp handler enabled
Using index info to reconstruct a base tree...
M	mono/metadata/icall.c
M	mono/mini/mini-runtime.c
M	mono/mini/mini-runtime.h
Falling back to patching base and 3-way merge...
Auto-merging mono/mini/mini-runtime.h
CONFLICT (content): Merge conflict in mono/mini/mini-runtime.h
Auto-merging mono/mini/mini-runtime.c
Auto-merging mono/metadata/icall.c
error: Failed to merge in the changes.
Patch failed at 0002 [runtime] Register sigtramp when merp handler enabled

Please backport manually!

* [runtime] Add a signal handler for sigterm * [runtime] Register sigtramp when merp handler enabled * [runtime] Limit sigterm handler symbol definition to OSX Commit migrated from mono/mono@24ef425

alexanderkyte requested review from kumpera and vargaz as code owners April 13, 2018 19:49

alexanderkyte force-pushed the sigterm_handler branch from 25c23ea to 9ad6cf1 Compare April 13, 2018 20:50

alexrp reviewed Apr 13, 2018

View reviewed changes

luhenry suggested changes Apr 13, 2018

View reviewed changes

mono/mini/mini-posix.c Outdated

Copy link

Contributor

luhenry Apr 13, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use g_hasenv

alexanderkyte force-pushed the sigterm_handler branch 4 times, most recently from 80fc8f2 to ccec018 Compare April 17, 2018 04:54

lewurm reviewed Apr 17, 2018

View reviewed changes

mono/mini/mini-posix.c Outdated

Copy link

Contributor

lewurm Apr 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be TARGET_OSX

luhenry reviewed Apr 17, 2018

View reviewed changes

alexanderkyte force-pushed the sigterm_handler branch 3 times, most recently from 4fc4407 to 01b3e83 Compare April 17, 2018 17:56

luhenry approved these changes Apr 17, 2018

View reviewed changes

lewurm approved these changes Apr 17, 2018

View reviewed changes

alexanderkyte added 3 commits April 19, 2018 19:25

[runtime] Add a signal handler for sigterm

3732e48

[runtime] Register sigtramp when merp handler enabled

dced887

[runtime] Limit sigterm handler symbol definition to OSX

9eaaeed

alexanderkyte force-pushed the sigterm_handler branch from 4560c91 to 9eaaeed Compare April 19, 2018 23:25

luhenry merged commit 24ef425 into mono:master Apr 20, 2018

This was referenced Apr 20, 2018

[2018-02] [runtime] Add a signal handler for sigterm #8383

Merged

[2018-04] [runtime] Add a signal handler for sigterm #8384

Merged

akoeplinger mentioned this pull request Apr 23, 2018

FullAOT test failures/crashes on arm64,armel or armhf #8409

Closed

kdubau mentioned this pull request Oct 18, 2019

[merp] generate a crash report if process is killed with SIGTERM #17419

Closed

[runtime] Add a signal handler for sigterm #8240

[runtime] Add a signal handler for sigterm #8240

Uh oh!

Conversation

alexanderkyte commented Apr 13, 2018 • edited by luhenry Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alexanderkyte commented Apr 13, 2018

Uh oh!

kumpera commented Apr 13, 2018

Uh oh!

migueldeicaza commented Apr 13, 2018

Uh oh!

vargaz commented Apr 13, 2018

Uh oh!

alexanderkyte commented Apr 13, 2018

Uh oh!

alexanderkyte commented Apr 13, 2018

Uh oh!

alexanderkyte commented Apr 13, 2018

Uh oh!

alexrp Apr 13, 2018

Choose a reason for hiding this comment

Uh oh!

luhenry Apr 13, 2018

Choose a reason for hiding this comment

Uh oh!

lewurm commented Apr 13, 2018

Uh oh!

luhenry Apr 13, 2018

Choose a reason for hiding this comment

Uh oh!

luhenry commented Apr 13, 2018

Uh oh!

lewurm Apr 17, 2018

Choose a reason for hiding this comment

Uh oh!

luhenry Apr 17, 2018

Choose a reason for hiding this comment

Uh oh!

alexanderkyte Apr 17, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

luhenry commented Apr 18, 2018

Uh oh!

luhenry commented Apr 20, 2018

Uh oh!

luhenry commented Apr 20, 2018

Uh oh!

luhenry commented Apr 20, 2018

Uh oh!

luhenry commented Apr 20, 2018

Uh oh!

luhenry commented Apr 20, 2018

Uh oh!

monojenkins commented Apr 20, 2018

Uh oh!

monojenkins commented Apr 20, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

alexanderkyte commented Apr 13, 2018 •

edited by luhenry

Loading

alexanderkyte Apr 17, 2018 •

edited

Loading