[2018-06] [MacOS] On Mac, use the copyfile API to copy files #9696
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copyfile is a high level API that does all the heavy lifting for copying files and does this in a Mac-correct way. We configure it to copy both the contents as well as the metadata and extended attributes in the file. Additionally, this uses COPYFILE_CLONE which will attempt to use the APFS clone capabilities for fast copies. On my Mac with APFS, copying a 5 gig file (Xcode) goes from taking 7.2 seconds to copy on an SSD to 0.5 seconds.
…nd define COPYFILE_CLONE to the right value
Contributor
|
I am biased, but this looks good to me. |
lewurm
approved these changes
Jul 25, 2018
Contributor
|
@monojenkins squash |
Contributor
|
@monojenkins build failed |
Contributor
Author
|
Cannot squash because the following required status checks are not successful:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #9642.
/cc @lewurm