"Code Ultramarine": sync X509Certificate2 with CoreFX and introduce X509Certificate2ImplUnix
#9705
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Overnight CI test results:
I'm going to rebase on top of current master, cherry-pick "Blue" on top of it, then apply all the other changes. |
6605338 to
5280b8b
Compare
d8e5cdb to
7c0691c
Compare
Sync `X509Certificate2` implementation with CoreFX, similar to how we did for `X509Certificate` in "Blue" (#9650). * Introducing `X509Certificate2ImplUnix` as new common base class for `X509CertificateImplApple`, `X509CertificateImplBtls` and `X509Certificate2ImplMono`. This uses the internal `CertificateData` class from CoreFX instead of the old "fallback" implementation from "Mono.Security". * `MonoBtlsProvider`, `X509CertificateImplBtls`: the "fallback" option has been removed since we now always provide this functionality via the managed `CertificateData`. * `X509CertificateImplMono`: This has been largely stripped down to use the new `X509CertificateImplUnix`.
7c0691c to
7775a22
Compare
X509Certificate2 with CoreFX and introduce X509Certificate2ImplUnix
Contributor
Author
|
@marek-safar This is an old PR that was left over from July. I rebased it on top of current master and cleaned it up a little bit. |
Contributor
Author
|
@monojenkins commit csproj |
Contributor
Author
|
@monojenkins build failed |
1 similar comment
Contributor
Author
|
@monojenkins build failed |
Member
|
@monojenkins commit apidiff |
monojenkins
added a commit
to mono/api-snapshot
that referenced
this pull request
Nov 29, 2018
marek-safar
approved these changes
Nov 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sync
X509Certificate2implementation with CoreFX, similar to how we did forX509Certificatein "Blue" (#9650).Introducing
X509Certificate2ImplUnixas new common base class forX509CertificateImplApple,X509CertificateImplBtlsandX509Certificate2ImplMono. This uses the internalCertificateDataclass from CoreFX instead of the old "fallback" implementation from "Mono.Security".MonoBtlsProvider,X509CertificateImplBtls: the "fallback" option has been removed since we now always provide this functionality via the managedCertificateData.X509CertificateImplMono: This has been largely stripped down to use the newX509CertificateImplUnix.