Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Coop] A bunch of nohandles(). #9738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jaykrell merged 10 commits into from
Jul 27, 2018
Merged

[Coop] A bunch of nohandles(). #9738

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
0663f95
[Coop] System.IO mark all remaining NOHANDLES().
jaykrell Jul 26, 2018
5026e7e
Functions take no parameters, not any parameters.
jaykrell Jul 26, 2018
b4e7b94
[Coop] Mark System.Threading.Interlocked as mostly NOHANDLES().
jaykrell Jul 26, 2018
5d2e033
[Coop] ves_icall_System_Threading_Thread_MemoryBarrier is NOHANDLES().
jaykrell Jul 26, 2018
a3e3e7b
[Coop] System.Threading volatile reads/writes are NOHANDLES().
jaykrell Jul 26, 2018
22e90ba
Make YieldInternal NOHANDLES and remove two potential layers.
jaykrell Jul 26, 2018
c2fcf9c
[Coop] Make ves_icall_System_Threading_Thread_current_lcid NOHANDLES().
jaykrell Jul 26, 2018
e6ffe1b
[Coop] mono_100ns_ticks nohandles.
jaykrell Jul 26, 2018
11c5765
[Coop] More nohandles volatile reads/writes.
jaykrell Jul 26, 2018
8488891
[Coop] NOHANDLES() System.Security.SecurityManager.
jaykrell Jul 26, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
216 changes: 108 additions & 108 deletions mono/metadata/icall-def.h
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions mono/metadata/locales.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -808,10 +808,10 @@ int ves_icall_System_Globalization_CompareInfo_internal_index_char (MonoCompareI
}

int
ves_icall_System_Threading_Thread_current_lcid (MonoError *error)
ves_icall_System_Threading_Thread_current_lcid (void)
{
/* Invariant */
return(0x007F);
return 0x007F;
}

static gint32 string_invariant_compare_char (gunichar2 c1, gunichar2 c2,
Expand Down
2 changes: 1 addition & 1 deletion mono/metadata/locales.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ extern void ves_icall_System_Globalization_CompareInfo_assign_sortkey (MonoCompa
extern int ves_icall_System_Globalization_CompareInfo_internal_index (MonoCompareInfo *this_obj, MonoString *source, gint32 sindex, gint32 count, MonoString *value, gint32 options, MonoBoolean first);
extern int ves_icall_System_Globalization_CompareInfo_internal_index_char (MonoCompareInfo *this_obj, MonoString *source, gint32 sindex, gint32 count, gunichar2 value, gint32 options, MonoBoolean first);
int
ves_icall_System_Threading_Thread_current_lcid (MonoError *error);
ves_icall_System_Threading_Thread_current_lcid (void);
extern MonoString *ves_icall_System_String_InternalToLower_Comp (MonoString *this_obj, MonoCultureInfo *cult);
extern MonoString *ves_icall_System_String_InternalToUpper_Comp (MonoString *this_obj, MonoCultureInfo *cult);
extern gunichar2 ves_icall_System_Char_InternalToUpper_Comp (gunichar2 c, MonoCultureInfo *cult);
Expand Down
3 changes: 0 additions & 3 deletions mono/metadata/threads-types.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,9 +100,6 @@ ves_icall_System_Threading_Thread_Join_internal (MonoThreadObjectHandle thread_h
gint32
ves_icall_System_Threading_Thread_GetDomainID (MonoError *error);

gboolean
ves_icall_System_Threading_Thread_Yield (MonoError *error);

MonoStringHandle ves_icall_System_Threading_Thread_GetName_internal (MonoInternalThreadHandle this_obj, MonoError *error);
void ves_icall_System_Threading_Thread_SetName_internal (MonoInternalThread *this_obj, MonoString *name);
int ves_icall_System_Threading_Thread_GetPriority (MonoThreadObjectHandle this_obj, MonoError *error);
Expand Down
6 changes: 0 additions & 6 deletions mono/metadata/threads.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1661,12 +1661,6 @@ ves_icall_System_Threading_Thread_GetDomainID (MonoError *error)
return mono_domain_get()->domain_id;
}

gboolean
ves_icall_System_Threading_Thread_Yield (MonoError *error)
{
return mono_thread_info_yield ();
}

/*
* mono_thread_get_name:
*
Expand Down
14 changes: 7 additions & 7 deletions mono/metadata/w32file.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -689,19 +689,19 @@ ves_icall_System_IO_MonoIO_SetFileTime (HANDLE handle, gint64 creation_time,
}

HANDLE
ves_icall_System_IO_MonoIO_get_ConsoleOutput ()
ves_icall_System_IO_MonoIO_get_ConsoleOutput (void)
Copy link
Contributor Author

@jaykrell jaykrell Jul 27, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These functions could be eliminated too.

{
return mono_w32file_get_console_output ();
}

HANDLE
ves_icall_System_IO_MonoIO_get_ConsoleInput ()
ves_icall_System_IO_MonoIO_get_ConsoleInput (void)
{
return mono_w32file_get_console_input ();
}

HANDLE
ves_icall_System_IO_MonoIO_get_ConsoleError ()
ves_icall_System_IO_MonoIO_get_ConsoleError (void)
{
return mono_w32file_get_console_error ();
}
Expand Down Expand Up @@ -758,19 +758,19 @@ ves_icall_System_IO_MonoIO_DuplicateHandle (HANDLE source_process_handle, HANDLE

#ifndef HOST_WIN32
gunichar2
ves_icall_System_IO_MonoIO_get_VolumeSeparatorChar ()
ves_icall_System_IO_MonoIO_get_VolumeSeparatorChar (void)
{
return (gunichar2) '/'; /* forward slash */
}

gunichar2
ves_icall_System_IO_MonoIO_get_DirectorySeparatorChar ()
ves_icall_System_IO_MonoIO_get_DirectorySeparatorChar (void)
{
return (gunichar2) '/'; /* forward slash */
}

gunichar2
ves_icall_System_IO_MonoIO_get_AltDirectorySeparatorChar ()
ves_icall_System_IO_MonoIO_get_AltDirectorySeparatorChar (void)
{
if (IS_PORTABILITY_SET)
return (gunichar2) '\\'; /* backslash */
Expand All @@ -779,7 +779,7 @@ ves_icall_System_IO_MonoIO_get_AltDirectorySeparatorChar ()
}

gunichar2
ves_icall_System_IO_MonoIO_get_PathSeparator ()
ves_icall_System_IO_MonoIO_get_PathSeparator (void)
{
return (gunichar2) ':'; /* colon */
}
Expand Down
4 changes: 1 addition & 3 deletions mono/utils/mono-merp.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,9 +342,7 @@ mono_init_merp (const intptr_t crashed_pid, const char *signal, MonoStackHash *h

merp->moduleOffset = 0;

ERROR_DECL (error);
merp->uiLidArg = ves_icall_System_Threading_Thread_current_lcid (error);
mono_error_assert_ok (error);
merp->uiLidArg = ves_icall_System_Threading_Thread_current_lcid ();

merp->osVersion = os_version_string ();

Expand Down