[remoting] Fix multithreaded appdomain marshalling #9783
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
280811d to
eb6b8e6
Compare
Contributor
Author
|
@monojenkins build failed |
BinarryFormatter is not thread-safe
eb6b8e6 to
7d49783
Compare
marek-safar
requested changes
Aug 2, 2018
Member
marek-safar
left a comment
There was a problem hiding this comment.
BinarryFormatter is not thread-safe but we are not using it from multiple threads. Could you link the fix to actual issue?
Contributor
Author
|
_comment/PR is wrong, but relevant issue was #8720 _ |
Contributor
Author
|
@monojenkins build pkg |
Contributor
Author
|
Sorry, this is all wrong, this is not like the earlier bug (#7150) where the serializer was in a static field. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[remoting] Fix multithreaded appdomain marshalling
BinarryFormatter is not thread-safe