[coop] Turn hybrid suspend on by default on desktop platforms #9811

lambdageek · 2018-07-30T21:32:24Z

Use hybrid suspend by default on x86 and amd64 OSX, Windows and Linux.

Pass --disable-hybrid-suspend to configure to disable at build time, or set
the enrivonment variable MONO_THREADS_SUSPEND=preemptive when running Mono to use preemptive suspend (the previous default).

Pass --disable-hybrid-suspend --enable-cooperative-suspend to configure
cooperative suspend at build time.

lambdageek · 2018-07-30T21:40:23Z

We should add an x64 Linux (and OSX?) preemptive suspend CI lane after this is merged so we can keep testing the previous configuration. (There's already a CI_TAGS keyword for it - CI_TAGS=preemptive-suspend)

luhenry

You need to disable it for iOS and Android in https://github.com/mono/mono/blob/master/sdks/builds/ios.mk and https://github.com/mono/mono/blob/master/sdks/builds/android.mk respectively. Only disable it on the devices and simulator builds, not the host ones (iOSDeviceTemplate, iOSSimulatorTemplate and AndroidTargetTemplate).

lambdageek · 2018-07-31T15:37:20Z

@luhenry Updated to explicitly pass --disable flags for the sdks

lambdageek · 2018-07-31T17:34:16Z

Now I'm second-guessing myself - do I actually want to check the HOST not the TARGET? this isn't an (AOT) compiler related feature so I think checking HOST is more correct.

lambdageek · 2018-07-31T22:02:25Z

Could I get another review of this? I switched the configure logic to look at HOST and host_linux and host_win32 (but target_osx - see comment in code).

I don't think it matters (since this isn't an AOT thing), but I'd love some feedback.

jaykrell · 2018-07-31T23:38:52Z

Good point. Host should be correct. "runtimes" only have a host. I mean, even if the AOT compiler itself used a garbage collector, and configurable suspension, "host" would be correct.

jaykrell · 2018-07-31T23:39:27Z

Unless the compiler had to inject safe points into the AOT code depending on suspension mechanism, then target could be relevant.

jaykrell · 2018-07-31T23:41:09Z

configure.ac

I'm not sure processor is relevant..but I guess ok, it disambiguates darwin, and we don't have Windows/arm support. What about Linux/arm?

FIXME? add host_macos, host_ios, and either remove host_darwin or make it clear host_darwin is maco | ios? And never say "osx"?

Does coop work w/o coop handles finished? We just treat transition from jit=>native differently based on if it is a handles() transition?

The processor check is specifically because we only want to turn this on on Intel for now - it feels like there are more deadlocks to chase down on linux on ARM.

The coop handles (plus precise managed stack scanning) would allow us to skip the "copy stackdata" step when a thread self-suspends and to stop scanning the native stack conservatively. So not having them doesn't preclude using hybrid suspend today.

jaykrell

Might want another authority on this but ok by me.

lambdageek · 2018-08-01T17:53:39Z

@monojenkins build failed

lambdageek · 2018-08-01T20:00:36Z

The interp failures seem related: we don't have GC Unsafe transitions in interp_entry.

@luhenry @lewurm What do you think: switch interp lane to use preemptive suspend for now and fixup later, or hold this PR until interp is ready?

luhenry · 2018-08-01T21:29:26Z

@lambdageek disabling on CI will not fix the Interpreter by default, so either we always disable Hybrid Suspend while running with the interpreter, either we fix the Interpreter. I would go for the latter one, but I don't have a good idea of how long it's going to take.

lambdageek · 2018-08-02T14:44:41Z

@luhenry The interpreter doesn't have safepoints right now - #7046 (comment). I'm not sure if there's a usecase for interp + hybrid on desktop. So I would prefer to go with a warning and a switch to preemptive if the interpreter and hybrid or coop are specified simultaneously.

luhenry · 2018-08-02T16:06:01Z

@lambdageek sounds good to me, let's do that. /cc @lewurm @BrzVlad

lambdageek · 2018-08-02T20:42:04Z

Updated to always switch to preemptive suspend if using the interpreter.

Use hybrid suspend by default on x86 and amd64 OSX, Windows and Linux Pass `--disable-hybrid-suspend` to configure to disable at build time, or set the enrivonment variable `MONO_THREADS_SUSPEND=preemptive` when running Mono to use preemptive suspend (the previous default). Pass `--disable-hybrid-suspend --enable-cooperative-suspend` to configure cooperative suspend at build time.

Only the devices and simulator builds, not the host ones.

Do not use it. It provides a last resort method to ignore configure and environment settings and use a hardcoded threads suspend policy.

Until the interpreter supports safepoints and performs threads suspend states switches in its trampolines, always use preemptive suspend if the interpreter is used.

Like other uses of mono_threads_join_lock, enter GC Safe before trying to take the lock.

lambdageek · 2018-08-03T19:30:21Z

Pushed a fix for sgen-new-threads-collect failures on OSX - need to take the join lock in GC Safe mode.

Move safepoint suspend check to mono_runtime_set_execution_mode

…orce preemptive suspend Force preemptive suspend in fullaotmixedcheck. We must compile the AOT images without safepoints.

… usable with embedding See mono/mono#9811. Hopefully this doesn't get removed.

…ono#9811) * [coop] Turn hybrid suspend on by default on desktop platforms Use hybrid suspend by default on x86 and amd64 OSX, Windows and Linux Pass `--disable-hybrid-suspend` to configure to disable at build time, or set the environment variable `MONO_THREADS_SUSPEND=preemptive` when running Mono to use preemptive suspend (the previous default). Pass `--disable-hybrid-suspend --enable-cooperative-suspend` to configure cooperative suspend at build time. * [sdks] Disable coop and hybrid suspend for iOS and Android Only the devices and simulator builds, not the host ones. * [coop] Add mono_threads_suspend_override_policy () Do not use it. It provides a last resort method to ignore configure and environment settings and use a hardcoded threads suspend policy. * [interp] Override suspend policy - warn and use preemptive Until the interpreter supports safepoints and performs threads suspend states switches in its trampolines, always use preemptive suspend if the interpreter is used. * [coop] Enter GC Safe around mono_threads_join_lock () Like other uses of mono_threads_join_lock, enter GC Safe before trying to take the lock. * [interp] Use preemptive suspend with --full-aot-interp Move safepoint suspend check to mono_runtime_set_execution_mode * [test] fullaotmixed - force preemptive suspend[test] fullaotmixed - force preemptive suspend Force preemptive suspend in fullaotmixedcheck. We must compile the AOT images without safepoints. Commit migrated from mono/mono@a7c699a

lambdageek requested review from luhenry and marek-safar as code owners July 30, 2018 21:32

lambdageek force-pushed the hybrid-suspend-desktop-default branch 2 times, most recently from 676ae02 to 598fcbd Compare July 30, 2018 21:38

marek-safar mentioned this pull request Jul 30, 2018

Hybrid Suspend #6921

Closed

23 tasks

luhenry suggested changes Jul 31, 2018

View reviewed changes

lambdageek requested review from jonpryor, rolfbjarne and vargaz as code owners July 31, 2018 15:29

lambdageek force-pushed the hybrid-suspend-desktop-default branch from be614db to 59c678c Compare July 31, 2018 22:00

jaykrell reviewed Jul 31, 2018

View reviewed changes

jaykrell approved these changes Jul 31, 2018

View reviewed changes

luhenry approved these changes Aug 1, 2018

View reviewed changes

lambdageek force-pushed the hybrid-suspend-desktop-default branch from 59c678c to 48b9dd8 Compare August 2, 2018 20:41

lambdageek requested a review from kumpera as a code owner August 2, 2018 20:41

lambdageek added 3 commits August 3, 2018 14:52

[sdks] Disable coop and hybrid suspend for iOS and Android

7d135a3

Only the devices and simulator builds, not the host ones.

[coop] Add mono_threads_suspend_override_policy ()

198f533

Do not use it. It provides a last resort method to ignore configure and environment settings and use a hardcoded threads suspend policy.

lambdageek added 2 commits August 3, 2018 14:52

[interp] Override suspend policy - warn and use preemptive

c0678fb

Until the interpreter supports safepoints and performs threads suspend states switches in its trampolines, always use preemptive suspend if the interpreter is used.

[coop] Enter GC Safe around mono_threads_join_lock ()

ffb1ca8

Like other uses of mono_threads_join_lock, enter GC Safe before trying to take the lock.

lambdageek force-pushed the hybrid-suspend-desktop-default branch from 48b9dd8 to ffb1ca8 Compare August 3, 2018 19:29

lambdageek requested a review from BrzVlad as a code owner August 3, 2018 19:29

lambdageek and others added 2 commits August 3, 2018 21:35

[interp] Use preemptive suspend with --full-aot-interp

51f5ff2

Move safepoint suspend check to mono_runtime_set_execution_mode

[test] fullaotmixed - force preemptive suspend[test] fullaotmixed - f…

560b21c

…orce preemptive suspend Force preemptive suspend in fullaotmixedcheck. We must compile the AOT images without safepoints.

lambdageek merged commit a7c699a into mono:master Aug 5, 2018

lambdageek mentioned this pull request Aug 6, 2018

[MacSDK] Turn on hybrid suspend for 64-bit Mac packages #9448

Closed

akoeplinger mentioned this pull request Aug 7, 2018

tests/src/baseservices/threading/readerwriterlockslim/upgrader.cs CoreCLR acceptance-test fails #9935

Closed

blattersturm added a commit to citizenfx/fivem that referenced this pull request Jul 31, 2019

scripting/mono: fix hangs on Linux due to Mono coop suspend not being…

a8b8f50

… usable with embedding See mono/mono#9811. Hopefully this doesn't get removed.

[coop] Turn hybrid suspend on by default on desktop platforms #9811

[coop] Turn hybrid suspend on by default on desktop platforms #9811

Uh oh!

Conversation

lambdageek commented Jul 30, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lambdageek commented Jul 30, 2018

Uh oh!

luhenry left a comment

Choose a reason for hiding this comment

Uh oh!

lambdageek commented Jul 31, 2018

Uh oh!

lambdageek commented Jul 31, 2018

Uh oh!

lambdageek commented Jul 31, 2018

Uh oh!

jaykrell commented Jul 31, 2018

Uh oh!

jaykrell commented Jul 31, 2018

Uh oh!

jaykrell Jul 31, 2018

Choose a reason for hiding this comment

Uh oh!

jaykrell Jul 31, 2018

Choose a reason for hiding this comment

Uh oh!

jaykrell Jul 31, 2018

Choose a reason for hiding this comment

Uh oh!

lambdageek Aug 1, 2018

Choose a reason for hiding this comment

Uh oh!

jaykrell left a comment

Choose a reason for hiding this comment

Uh oh!

lambdageek commented Aug 1, 2018

Uh oh!

lambdageek commented Aug 1, 2018

Uh oh!

luhenry commented Aug 1, 2018

Uh oh!

lambdageek commented Aug 2, 2018

Uh oh!

luhenry commented Aug 2, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lambdageek commented Aug 2, 2018

Uh oh!

lambdageek commented Aug 3, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

lambdageek commented Jul 30, 2018 •

edited

Loading

luhenry commented Aug 2, 2018 •

edited

Loading