New cast to double and float for BigInteger #930
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The new helper method LeadingZeroCount returns the number of bits that are set to 0 at the start of an uint.
- The new implementation converts directly to double or float.
- Added overloads for PopulationCount and LeadingZeroCount that take ulong. - Added helper method BuildDouble that constructs a double by sign, mantissa and exponent. This method truncates the mantissa, thus may differ in rounding to Math.Pow. - The new implementation avoids Math.Pow by using BuildDouble. - Passing all recently added tests.
- The new implementation casts to double and then to float.
marek-safar
added a commit
that referenced
this pull request
Mar 5, 2014
New cast to double and float for BigInteger
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced the old convertion code with a direct cast to double and an indirect to float passing through double, also extended the tests for the cast. The new code will only read the most significant words of the BigInteger and therfore avoiding iterating over the whole value allowing for execution in near constant time [some cases take a short path].
Also added some new helper methods: