Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@addaleax
Copy link
Collaborator

Unfortunately, I don't think there's a way to express "when updating mongosh dependencies, bump these other dependencies to the same version used by the new mongosh dependency versions", so this will keep requiring some human attention.

Refs: #7521 (review)

Description

Checklist

  • New tests and/or benchmarks are included
  • Documentation is changed or added
  • If this change updates the UI, screenshots/videos are added and a design review is requested
  • I have signed the MongoDB Contributor License Agreement (https://www.mongodb.com/legal/contributor-agreement)

Motivation and Context

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Open Questions

Dependents

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

…pdate config

Unfortunately, I don't think there's a way to express "when updating mongosh
dependencies, bump these other dependencies to the same version used by
the new mongosh dependency versions", so this will keep requiring some human
attention.

Refs: #7521 (review)
@addaleax addaleax requested a review from a team as a code owner October 31, 2025 13:46
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds additional MongoDB driver and devtools-connect dependencies to the mongosh autoupdate configuration to ensure they are updated together with mongosh packages.

  • Added driver dependencies (mongodb, bson, kerberos, socks, mongodb-client-encryption) to mongosh update group
  • Added devtools packages (@mongodb-js/devtools-connect, @mongodb-js/devtools-proxy-support) to mongosh update group
  • Converted mongosh array from single-line to multi-line format with explanatory comments

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@addaleax addaleax added the no-title-validation Skips validation of PR titles (conventional commit adherence + JIRA ticket inclusion) label Oct 31, 2025
Copy link
Collaborator

@gribnoysup gribnoysup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm, so what we actually need here is more like: first, resolve latest mongosh versions, then from there resolve shared deps but based on mogosh, right? If yes, then yeah, we definitely weren't anticipating this needed, but doesn't sound like it would be too hard to do on top of what we have right now, can take a stab at it later

That's a super helpful starting point though to keep track of what needs to be included though!

@addaleax
Copy link
Collaborator Author

Yeah, and it's also not like it's always a bad thing if we update some of these dependencies to a newer version than what mongosh comes with. We can just see how well this one works for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-title-validation Skips validation of PR titles (conventional commit adherence + JIRA ticket inclusion)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants