PYTHON-3881 [WinKerberos] Support Python 3.7-3.12 #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
behackett
reviewed
Jul 28, 2023
| ], | ||
| ) | ||
| ], | ||
| cmdclass={"doc": doc} |
There was a problem hiding this comment.
The README tells you to use the doc directive with setup.py to build the docs with Sphinx. Does that still work?
There was a problem hiding this comment.
No, I updated the instructions
ShaneHarvey
reviewed
Jul 28, 2023
README.rst
Outdated
|
|
||
| python setup.py doc | ||
| cd doc | ||
| cmd.exe /c 'make.bat html SPHINXOPTS="-W"' |
There was a problem hiding this comment.
What about python -m sphinx -b html doc ...?
behackett
approved these changes
Jul 28, 2023
ShaneHarvey
approved these changes
Jul 31, 2023
jborean93
reviewed
Aug 8, 2023
| @@ -0,0 +1,38 @@ | |||
| [build-system] | |||
| requires = ["setuptools"] | |||
There was a problem hiding this comment.
You should add a lower bound of setuptools >= 61.0.0 as that's when setuptools added support for pyproject.toml. If pip or other build tools end up using an earlier version it will fail to build your package.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.