Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Raise an error when an aggregate expression contains more than one fi… #557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pcorpet merged 1 commit into from
Sep 28, 2019
Merged

Raise an error when an aggregate expression contains more than one fi… #557

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions mongomock/aggregate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,12 @@ def parse(self, expression):
if not isinstance(expression, dict):
return self._parse_basic_expression(expression)

if len(expression) > 1 and any(key.startswith('$') for key in expression):
raise OperationFailure(
'an expression specification must contain exactly one field, '
'the name of the expression. Found %d fields in %s'
% (len(expression), expression))

value_dict = {}
for k, v in six.iteritems(expression):
if k in arithmetic_operators:
Expand Down
7 changes: 7 additions & 0 deletions tests/test__collection_api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3335,6 +3335,13 @@ def test__aggregate_project_rotate(self):
])
self.assertEqual([{'_id': 1, 'a': 2, 'b': 1, 'c': 3}], list(actual))

def test__aggregate_mixed_expression(self):
self.db.collection.insert_one({'_id': 1, 'arr': [2, 3]})
with self.assertRaises(mongomock.OperationFailure):
self.db.collection.aggregate([
{'$project': {'a': {'$literal': False, 'hint': False}}},
])

def test__find_type_array(self):
self.db.collection.insert_one({'_id': 1, 'arr': [1, 2]})
self.db.collection.insert_one({'_id': 2, 'arr': {'a': 4, 'b': 5}})
Expand Down