collection.py: Fix return value of Collection.documents_count() #586
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #586 +/- ##
===========================================
- Coverage 94.75% 94.75% -0.01%
===========================================
Files 16 16
Lines 3144 3143 -1
===========================================
- Hits 2979 2978 -1
Misses 165 165
Continue to review full report at Codecov.
|
pcorpet
requested changes
Jan 16, 2020
Member
pcorpet
left a comment
There was a problem hiding this comment.
Thanks for your change, please add a test in test__mongomock so we do not have regressions in the future.
When skip was greater than count for collection.Collection.document_count() the method kept returning negative values It returns 0 now, which is the expected behaviour. Signed-off-by: Michal Galka <[email protected]>
ac152c6 to
52fc9a7
Compare
Contributor
Author
I added the tests. |
pcorpet
approved these changes
Jan 16, 2020
Member
|
Thanks for the quick turnaround on that issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When skip was greater than count for
collection.Collection.document_count() the method kept returning
negative values It returns 0 now, which is the expected behaviour.
Fixes Issue #585