Fix for {$size: 1} queries on non-existent fields #711
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #711 +/- ##
==========================================
Coverage ? 95.38%
==========================================
Files ? 19
Lines ? 3640
Branches ? 0
==========================================
Hits ? 3472
Misses ? 168
Partials ? 0
Continue to review full report at Codecov.
|
|
Thanks for spotting and fixing that bug. |
|
No problem @pcorpet, thanks for the quick review. mongomock is super useful for testing and validation over at https://github.com/Materials-Consortia/optimade-python-tools and https://www.optimade.org/, so thanks for all your hard work. I don't know what your release schedule is, but we would really appreciate a patch release for this, if that works for you! |
|
Thanks for the kind words, I'll try to get few more fixes in and then release. |
Closes #710 and looks related to the fixes in #697.
Currently, if a missing field is queried with
{field: {"$size": 1}}, all documents without that field will match, asbool(NOTHING)evaluates toTrue.This PR checks explicitly whether the missing field
$sizeisNOTHING(indicating that the field value could not be parsed as an array, see #697).The first commit in this PR adds a test for the current bug (so the CI should fail), and the second provides the fix.