Thanks to visit codestin.com
Credit goes to github.com

Skip to content

added support for allow_disk_use #780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pcorpet merged 5 commits into from
Jun 21, 2022
Merged

added support for allow_disk_use #780

pcorpet merged 5 commits into from
Jun 21, 2022

Conversation

@adamsqi
Copy link
Contributor

@adamsqi adamsqi commented Jun 9, 2022

@codecov
Copy link

codecov bot commented Jun 9, 2022 •
edited
Loading

Codecov Report

Merging #780 (ce19172) into develop (e7d9ded) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop     #780   +/-   ##
========================================
  Coverage    95.22%   95.23%           
========================================
  Files           20       20           
  Lines         3793     3797    +4     
========================================
+ Hits          3612     3616    +4     
  Misses         181      181
Impacted Files Coverage Δ
mongomock/collection.py 92.51% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7d9ded...ce19172. Read the comment docs.

pcorpet
pcorpet requested changes Jun 12, 2022
View reviewed changes
Copy link
Member

@pcorpet pcorpet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your change.

Please add a usage in any of existing test or copy an existing one to set it with True or False and check that there are no errors (for regression).

Disregard the broken pylint, I'll take care of it.

@adamsqi
Copy link
Contributor Author

adamsqi commented Jun 13, 2022

@pcorpet
Hi, I can see there is an issue with:
W: GPG error: https://packages.erlang-solutions.com/ubuntu focal Release: The following signatures were invalid: BADSIG D208507CA14F4FCA Erlang Solutions Ltd. <[email protected]>
in Travis Cl

@adamsqi adamsqi requested a review from pcorpet June 13, 2022 08:43
@adamsqi
Copy link
Contributor Author

adamsqi commented Jun 21, 2022

Hi @pcorpet, have you had time to look at this PR?

@pcorpet
Copy link
Member

pcorpet commented Jun 21, 2022

@pcorpet Hi, I can see there is an issue with: W: GPG error: https://packages.erlang-solutions.com/ubuntu focal Release: The following signatures were invalid: BADSIG D208507CA14F4FCA Erlang Solutions Ltd. <[email protected]> in Travis Cl

Can you try rebasing on HEAD of develop please?

@pcorpet
Copy link
Member

pcorpet commented Jun 21, 2022

Please add a usage in any of existing test or copy an existing one to set it with True or False and check that there are no errors (for regression).

Add a usage of the keyword argument as well in a test.

@adamsqi adamsqi force-pushed the support_allow_disk_use branch from 9057059 to da28b1e Compare June 21, 2022 10:39
@pcorpet pcorpet merged commit 886e93b into mongomock:develop Jun 21, 2022
@pcorpet
Copy link
Member

pcorpet commented Jun 21, 2022

Thanks for your changes!

@adamsqi
Copy link
Contributor Author

adamsqi commented Jun 21, 2022

@pcorpet thank you! When do you plan to release a new version?

robberry90 pushed a commit to robberry90/mongomock that referenced this pull request Feb 4, 2023
@adamsqi @robberry90
Add support for allow_disk_use (mongomock#780)
7e21ade
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pcorpet pcorpet Awaiting requested review from pcorpet

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@adamsqi @pcorpet