Fix collection.find_one(...) sorting using dicts #897
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ey"], failing to unwrap the sorting direction.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #897 +/- ##
========================================
Coverage 95.75% 95.76%
========================================
Files 35 35
Lines 10017 10027 +10
========================================
+ Hits 9592 9602 +10
Misses 425 425 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to find one element and sorting
collection.find_one(filter, sort={"key", -1})there is a problem inside_get_datasetbecauseor, with a different syntax:
So it fails to unpack the
sort_direction.This PR addresses that issue by checking if the
sortargument is a dictionary, as it could also be a list of tuples(key, direction)and transforming that dictionary intodict_itemsso that they can be reversed in the same fashion,(key, direction).