Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@wenxuwan
Copy link
Member

@wenxuwan wenxuwan commented May 11, 2022

What this PR does:

Which issue(s) this PR fixes:

Fixes #510

Special notes for your reviewer:

对于支持S3的原因可以参考 #510

Does this PR introduce a user-facing change?:


@seeflood seeflood changed the title layotto support s3 [WIP]feat: layotto support s3 May 13, 2022
@seeflood
Copy link
Member

seeflood commented Jul 23, 2022

@wenxuwan Looks good to me overall. Please fix the CI failure.
Thanks!

There are many things we have to do after this PR is merged, and I record them at #723

@seeflood seeflood closed this Jul 25, 2022
@seeflood seeflood reopened this Jul 25, 2022
zhenjunMa
zhenjunMa previously approved these changes Jul 25, 2022
Copy link
Member

@seeflood seeflood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

proposal: make file api Portable

4 participants