Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(types): add brokers interface #585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 24, 2021
Merged

fix(types): add brokers interface #585

merged 5 commits into from
Feb 24, 2021

Conversation

@getlarge
Copy link
Member

Add missing interface

@coveralls
Copy link

coveralls commented Feb 23, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 595269546

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.545%
Totals Coverage Status
Change from base Build 527809816: 0.0%
Covered Lines: 786
Relevant Lines: 787
💛 - Coveralls

robertsLando
robertsLando approved these changes Feb 23, 2021
View reviewed changes
Copy link
Member

@robertsLando robertsLando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mcollina
mcollina requested changes Feb 23, 2021
View reviewed changes
Copy link
Collaborator

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests are missing

@getlarge
Copy link
Member Author

@mcollina i don't see what could be added in test/types/index.ts.
Something like : const { brokers } = broker would be enough ?

@mcollina
Copy link
Collaborator

Yes!

@mcollina
Copy link
Collaborator

You can also use expectType assertion from tsd

mcollina
mcollina approved these changes Feb 24, 2021
View reviewed changes
Copy link
Collaborator

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@robertsLando robertsLando changed the title fix: add brokers interface fix(types): add brokers interface Feb 24, 2021
@robertsLando robertsLando merged commit 234f49a into moscajs:master Feb 24, 2021
@robertsLando
Copy link
Member

@getlarge Wait until also PR #584 get merged for a new release

@gnought
Copy link
Collaborator

gnought commented Mar 13, 2021

@getlarge It is suppose broker property in Aedes is for internal usage. Any reasons behind / user cases are there to require the broker interface?

@getlarge
Copy link
Member Author

@gnought It's related to that PR, aedes-persistence is using Brokers interface.

@snyk-bot snyk-bot mentioned this pull request Mar 26, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollina mcollina mcollina approved these changes

@robertsLando robertsLando robertsLando approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@getlarge @coveralls @mcollina @robertsLando @gnought