Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@gnought
Copy link
Collaborator

@gnought gnought commented Mar 18, 2022

We support nodejs >= 12, a right time to drop readable-stream?

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2002370707

  • 0 of 4 (100.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.911%

Totals Coverage Status
Change from base Build 1952182561: 0.0%
Covered Lines: 802
Relevant Lines: 802

💛 - Coveralls

@coveralls
Copy link

coveralls commented Mar 18, 2022

Pull Request Test Coverage Report for Build 2002370707

  • 4 of 4 (100.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.911%

Totals Coverage Status
Change from base Build 1952182561: 0.0%
Covered Lines: 802
Relevant Lines: 802

💛 - Coveralls

Copy link
Member

@robertsLando robertsLando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gnought gnought merged commit 2ed6376 into moscajs:main Mar 18, 2022
@gnought gnought deleted the feature/drop-readable-stream branch April 17, 2022 11:04
@coveralls
Copy link

coveralls commented Nov 22, 2024

Pull Request Test Coverage Report for Build 2002370707

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.911%

Totals Coverage Status
Change from base Build 1952182561: 0.0%
Covered Lines: 802
Relevant Lines: 802

💛 - Coveralls

chfritz pushed a commit to chfritz/aedes that referenced this pull request Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants