Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore: drop bulk-write-stream #731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 19, 2022
Merged

chore: drop bulk-write-stream #731

merged 1 commit into from
Apr 19, 2022

Conversation

@gnought
Copy link
Collaborator

@gnought gnought commented Apr 19, 2022

This aims to reduce one dependency.
Hope I implement well for writev function

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2187668459

  • 0 of 4 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+8.0e**-05%**) to 99.911%
Totals Coverage Status
Change from base Build 2179826039: 8.0e-05%
Covered Lines: 803
Relevant Lines: 803
💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2187668459

  • 4 of 4 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+8.0e**-05%**) to 99.911%
Totals Coverage Status
Change from base Build 2179826039: 8.0e-05%
Covered Lines: 803
Relevant Lines: 803
💛 - Coveralls

mcollina
mcollina approved these changes Apr 19, 2022
View reviewed changes
Copy link
Collaborator

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@robertsLando robertsLando changed the title drop bulk-write-stream chore: drop bulk-write-stream Apr 19, 2022
@gnought gnought merged commit 0786082 into main Apr 19, 2022
@gnought gnought deleted the feat/drop-bulk-write-stream branch April 19, 2022 10:55
chfritz pushed a commit to chfritz/aedes that referenced this pull request Feb 3, 2025
@gnought @chfritz
chore: drop bulk-write-stream (moscajs#731)
a601972
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollina mcollina mcollina approved these changes

@robertsLando robertsLando robertsLando approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@gnought @coveralls @mcollina @robertsLando