Thanks to visit codestin.com
Credit goes to github.com

Skip to content

No messageId in QoS 0 #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 16, 2019
Merged

No messageId in QoS 0 #261

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,26 +39,26 @@
"author": "Matteo Collina <[email protected]>",
"license": "MIT",
"devDependencies": {
"@types/node": "^12.0.10",
"@types/node": "^12.6.3",
"compute-mode": "^1.0.0",
"concat-stream": "^2.0.0",
"convert-hrtime": "^3.0.0",
"coveralls": "^3.0.4",
"coveralls": "^3.0.5",
"duplexify": "^4.1.1",
"faucet": "0.0.1",
"mqtt": "^3.0.0",
"mqtt-connection": "^4.0.0",
"nyc": "^14.1.1",
"pre-commit": "^1.2.2",
"standard": "^12.0.1",
"tape": "^4.10.2",
"standard": "^13.0.2",
"tape": "^4.11.0",
"tslint": "^5.18.0",
"tslint-config-standard": "^8.0.1",
"typescript": "^3.5.2",
"typescript": "^3.5.3",
"websocket-stream": "^5.5.0"
},
"dependencies": {
"aedes-packet": "^1.0.0",
"aedes-packet": "^2.0.0",
"aedes-persistence": "^6.0.0",
"bulk-write-stream": "^2.0.0",
"end-of-stream": "^1.4.1",
Expand All @@ -67,7 +67,7 @@
"fastseries": "^1.7.2",
"from2": "^2.3.0",
"mqemitter": "^3.0.0",
"mqtt-packet": "^6.1.2",
"mqtt-packet": "^6.2.0",
"pump": "^3.0.0",
"retimer": "^2.0.0",
"reusify": "^1.0.4",
Expand Down
3 changes: 0 additions & 3 deletions test/auth.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,7 +332,6 @@ test('authorize publish', function (t) {
s.broker.mq.on('hello', function (packet, cb) {
expected.brokerId = s.broker.id
expected.brokerCounter = s.broker.counter
expected.messageId = 0
delete expected.dup
delete expected.length
t.deepEqual(packet, expected, 'packet matches')
Expand Down Expand Up @@ -379,7 +378,6 @@ test('authorize waits for authenticate', function (t) {
s.broker.mq.on('hello', function (packet, cb) {
expected.brokerId = s.broker.id
expected.brokerCounter = s.broker.counter
expected.messageId = 0
delete expected.dup
delete expected.length
t.deepEqual(packet, expected, 'packet matches')
Expand Down Expand Up @@ -428,7 +426,6 @@ test('authorize publish from configOptions', function (t) {
s.broker.mq.on('hello', function (packet, cb) {
expected.brokerId = s.broker.id
expected.brokerCounter = s.broker.counter
expected.messageId = 0
delete expected.dup
delete expected.length
t.deepEqual(packet, expected, 'packet matches')
Expand Down
4 changes: 2 additions & 2 deletions test/basic.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,13 +92,13 @@ test('publish QoS 0', function (t) {
topic: 'hello',
payload: Buffer.from('world'),
qos: 0,
retain: false,
messageId: 0
retain: false
}

s.broker.mq.on('hello', function (packet, cb) {
expected.brokerId = s.broker.id
expected.brokerCounter = s.broker.counter
t.equal(packet['messageId'], undefined, 'MUST not contain a packet identifier in QoS 0')
t.deepEqual(packet, expected, 'packet matches')
cb()
t.end()
Expand Down