feat(vault-v2): market v1 adapter #434
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…V1Adapter interfaces
…ramsList and update fetch logic
…market-v1-adapter
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for Morpho Market V1 adapters in the VaultV2 system by introducing VaultV2MorphoMarketV1Adapter classes and their corresponding fetch utilities. This extends the existing VaultV2 adapter architecture to support direct market interactions alongside the existing vault V1 adapters.
Key Changes:
- Introduced
VaultV2MorphoMarketV1AdapterandAccrualVaultV2MorphoMarketV1Adapterclasses for handling market-based adapters - Added fetch utilities and deployless query contracts for market V1 adapters
- Made the
timestampparameter optional in accrual methods to support both adapter types
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
packages/blue-sdk/src/vault/v2/index.ts |
Exports the new market V1 adapter |
packages/blue-sdk/src/vault/v2/VaultV2MorphoMarketV1Adapter.ts |
Defines core market V1 adapter classes with allocation logic |
packages/blue-sdk/src/vault/v2/VaultV2MorphoVaultV1Adapter.ts |
Makes timestamp parameter optional for consistency |
packages/blue-sdk/src/vault/Vault.ts |
Makes timestamp parameter optional in accrual methods |
packages/blue-sdk-viem/src/fetch/vault-v2/VaultV2Adapter.ts |
Updates adapter detection to support market V1 adapters |
packages/blue-sdk-viem/src/fetch/vault-v2/VaultV2MorphoMarketV1Adapter.ts |
Implements fetch logic for market V1 adapters |
packages/blue-sdk-viem/src/queries/vault-v2/GetVaultV2MorphoMarketV1Adapter.ts |
Deployless query contract bytecode and ABI |
packages/blue-sdk-viem/src/abis.ts |
Adds ABIs for market V1 adapter and factory contracts |
packages/blue-sdk-viem/contracts/vault-v2/interfaces/IMorphoMarketV1Adapter.sol |
Defines Solidity interface for market V1 adapters |
packages/blue-sdk-viem/contracts/vault-v2/GetVaultV2MorphoMarketV1Adapter.sol |
Deployless query contract implementation |
packages/blue-sdk-viem/test/VaultV2Adapter.test.ts |
Adds tests for market V1 adapter and refactors existing tests |
packages/blue-sdk-viem/test/setup.ts |
Updates fork block number for testing |
packages/blue-sdk-viem/src/fetch/Vault.ts |
Minor refactor from Array.from to .map() |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
packages/blue-sdk-viem/src/fetch/vault-v2/VaultV2MorphoMarketV1Adapter.ts
Outdated
Show resolved
Hide resolved
Rubilmax
commented
Oct 16, 2025
| }); | ||
|
|
||
| describe("LiquidityAdapter", () => { | ||
| describe("maxDeposit function", () => { |
There was a problem hiding this comment.
IMO we should add a maxWithdraw test case limited by market liquidity
Foulks-Plb
approved these changes
Oct 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes DVXSDK-33