Fix #135 #136
Merged
Fix #135 #136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make an exception for https://github.com/pyqt/python-qt5
Owner
Author
|
Let me know if this works for you, @BigRoy. |
|
This seems to work! :) |
…untime With this in place, users will be able to keep an eye on things that change, in case some part of their code relies on the functionality remaining consistent.
| # Keep track of modifications | ||
| __modified__.append(name) | ||
|
|
||
| if name not in __added__: |
Owner
Author
There was a problem hiding this comment.
This is a minor bugfix; before, members in __added__ were also in __remapped__.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make an exception for https://github.com/pyqt/python-qt5.