loadUi: load custom widgets with PySide(2) #306
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
houndci-bot
reviewed
Dec 21, 2018
5f42f2b to
fb70b66
Compare
houndci-bot
reviewed
Dec 21, 2018
1f747be to
6be2ca0
Compare
houndci-bot
reviewed
Dec 21, 2018
6be2ca0 to
788dd51
Compare
- Workaround to pyside-77 bug which causes a crash (by using registerCustomWidget)
Contributor
Author
|
Is it okay for you ? |
Owner
|
Yes! Thanks for this, including a test; excellent work. |
Owner
|
How confusing; the issue reads as open, and merged, and closed at the same time. It was merged, right here. Closing this (again). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workaround to pyside-77 bug.
From the
QUiLoaderdoc we should use registerCustomWidget method to handle custom widgets.But on some platforms, this is causing a segfault by calling QUiLoader.createWidget.
So instead we fetch from customwidgets DOM node the python class objects.
Then we can directly use them in
createWidgetmethod.This also fixes #295.