Update error message for failure to parse preferred JSON #336
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Mar 13, 2020
Qt.py
Outdated
| # Python 2 raises ValueError, Python 3 raises json.JSONDecodeError | ||
| # a subclass of ValueError | ||
| _log("JSONDecodeError: {}".format(e)) | ||
| _warn("Failed to parse QT_PREFERRED_BINDING_JSON='%s'" % QT_PREFERRED_BINDING_JSON) |
There was a problem hiding this comment.
line too long (95 > 79 characters)
houndci-bot
reviewed
Mar 13, 2020
Qt.py
Outdated
| # a subclass of ValueError | ||
| _log("JSONDecodeError: {}".format(e)) | ||
| _warn("Failed to parse QT_PREFERRED_BINDING_JSON='%s'" | ||
| % QT_PREFERRED_BINDING_JSON) |
There was a problem hiding this comment.
continuation line over-indented for visual indent
MHendricks
reviewed
Mar 13, 2020
Comment on lines
611
to
615
| print('out------------------') | ||
| print(out) | ||
|
|
||
| print('err ------------------') | ||
| print(err) |
Collaborator
There was a problem hiding this comment.
Wow, I left a lot of debug prints from trying to debug my tests. These can probably be removed. I don't think they are useful anymore.
Owner
Author
There was a problem hiding this comment.
It's fine. Let's blame it on corona.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Qt.py can print an error on import that looks like..
But it doesn't tell you why, and if you aren't familiar with the new
QT_PREFERRED_BINDING_JSONvariable then I expect we'll see issues pop up here.I've changed that message to: