Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@volkm
Copy link
Contributor

@volkm volkm commented Aug 20, 2025

Added CMake option STORM_WARNING_AS_ERROR and enabled it in the CI to treat all warnings as errors.

Currently, the flag is used for all configurations in the CI which leads to a number of warnings which should be fixed.

@sjunges
Copy link
Contributor

sjunges commented Aug 22, 2025

This will be very helpful. I was wondering; just like we disabled quite some warnings on mac/clang right now, maybe we should disable the massive amount of unused-parameter warnings for now, get this PR merged, and then offer someone a box of chocolates to handle the unused parameters?

@volkm
Copy link
Contributor Author

volkm commented Aug 22, 2025

I disabled the unused parameter warnings when using STORM_WARNING_AS_ERROR. The CI moves a bit further now and I can take a look at some of the other warnings in due time.

How can I handle this warning? It is a custom warning so I am not sure how to ignore it. I tried using the CMake flag STORM_WARNING_AS_ERROR but I would also need to export it into the config which seems a bit overhead for one warning.

@sjunges
Copy link
Contributor

sjunges commented Aug 22, 2025

How about CMake's add_compile_definitions( ... )

@volkm
Copy link
Contributor Author

volkm commented Aug 22, 2025

Needs #765

@volkm volkm mentioned this pull request Sep 1, 2025
@volkm
Copy link
Contributor Author

volkm commented Sep 2, 2025

Most of the warnings should be fixed now. There are still at least three types of warnings open, but I am currently not knowledgeable enough to fix them. If you know how to address them, feel free to let me know.

@volkm
Copy link
Contributor Author

volkm commented Sep 5, 2025

All warnings should be fixed now. Thanks to @sjunges for some pointers on how to fix them.

There are even more warnings if we enable STORM_ALLWARNINGS but this is a separate task for another time.

@volkm volkm marked this pull request as ready for review September 5, 2025 15:27
Copy link
Member

@tquatmann tquatmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Many Thanks!

@volkm volkm mentioned this pull request Oct 1, 2025
@volkm
Copy link
Contributor Author

volkm commented Oct 1, 2025

We opted to first merge the fixes to warnings in the source code, see #792. Afterwards, we can address the remaining CMake questions here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants