-
Couldn't load subscription status.
- Fork 83
Treat warnings as errors in CI #757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
This will be very helpful. I was wondering; just like we disabled quite some warnings on mac/clang right now, maybe we should disable the massive amount of unused-parameter warnings for now, get this PR merged, and then offer someone a box of chocolates to handle the unused parameters? |
|
I disabled the unused parameter warnings when using How can I handle this warning? It is a custom warning so I am not sure how to ignore it. I tried using the CMake flag |
|
How about CMake's add_compile_definitions( ... ) |
|
Needs #765 |
|
Most of the warnings should be fixed now. There are still at least three types of warnings open, but I am currently not knowledgeable enough to fix them. If you know how to address them, feel free to let me know. |
|
All warnings should be fixed now. Thanks to @sjunges for some pointers on how to fix them. There are even more warnings if we enable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Many Thanks!
|
We opted to first merge the fixes to warnings in the source code, see #792. Afterwards, we can address the remaining CMake questions here. |
Added CMake option
STORM_WARNING_AS_ERRORand enabled it in the CI to treat all warnings as errors.Currently, the flag is used for all configurations in the CI which leads to a number of warnings which should be fixed.