Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add new EntityId variant for tool results #569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 26, 2025
Merged

Add new EntityId variant for tool results #569

merged 1 commit into from
Sep 26, 2025

Conversation

@joulei
Copy link
Collaborator

@joulei joulei commented Sep 26, 2025

Introduces EntityId::Tool for tool call results, we were previously using EntityId::System which should be used for things like system prompts instead.

New EntityId usage:

- User message → `EntityId::User` (unchanged)
- Assistant response with tool calls → EntityId::Bot(bot_id) // these are regular messages that also include tool calls, some providers even include a reglar text like "yes, let me navigate to wikipedia", and alongside that the tool call.
- Tool execution results → EntityId::Tool (new variant)
- Assistant response to tool results → EntityId::Bot(bot_id)
- System prompts/context → EntityId::System (unchanged)
- App errors/notifications → EntityId::App (unchanged)

@joulei joulei merged commit 046efab into main Sep 26, 2025
7 checks passed
@joulei joulei deleted the bot-entitiy-id-for-tools branch September 26, 2025 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@joulei