Implement stream_get_latency for the opensl backend.
#535
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
48e24cd to
7a084a7
Compare
achronop
approved these changes
Sep 3, 2019
src/cubeb_opensl.c
Outdated
| uint32_t stream_latency_frames = | ||
| (stm->user_output_rate * stm->output_latency_ms) / 1000; | ||
|
|
||
| if (stm->resampler) { |
There was a problem hiding this comment.
The resampler is always there, look at [1], better assert if you want to verify.
[1] https://github.com/kinetiknz/cubeb/blob/master/src/cubeb_opensl.c#L1379
src/cubeb_opensl.c
Outdated
| static int | ||
| opensl_stream_get_latency(cubeb_stream * stm, uint32_t * latency) | ||
| { | ||
| assert(stm && latency); |
There was a problem hiding this comment.
I prefer to break that kind of asserts into 2 separate individual asserts since it is easier to find out which one has been hit. Not a strong comment.
src/cubeb_opensl.c
Outdated
| assert(stm && latency); | ||
|
|
||
| uint32_t stream_latency_frames = | ||
| (stm->user_output_rate * stm->output_latency_ms) / 1000; |
There was a problem hiding this comment.
It does not change anything but since the user_output_rate is samples per seconds and the output_latency_ms is in ms I would prefer different parenthesis:
stm->user_output_rate * (stm->output_latency_ms / 1000)
7a084a7 to
5a8950c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.