Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Return early when the length of incoming data is zero #597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Return early when the length of incoming data is zero #597

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/cubeb_utils.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,6 +192,9 @@ class auto_array
*/
void push(const T * elements, size_t length)
{
if (!length) {
return;
}
if (length_ + length > capacity_) {
reserve(length_ + length);
}
Expand All @@ -205,6 +208,9 @@ class auto_array
*/
void push_silence(size_t length)
{
if (!length) {
return;
}
if (length_ + length > capacity_) {
reserve(length + length_);
}
Expand All @@ -218,6 +224,9 @@ class auto_array
*/
void push_front_silence(size_t length)
{
if (!length) {
return;
}
if (length_ + length > capacity_) {
reserve(length + length_);
}
Expand Down
18 changes: 18 additions & 0 deletions test/test_utils.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,3 +70,21 @@ TEST(cubeb, auto_array)
ASSERT_EQ(array.capacity(), 20u);
}

// On debug build this was crashing in PodMove/Zero/Copy() methods
// used by auto_array
TEST(cubeb, auto_array_zero_length_crash)
{
auto_array<float> array;

ASSERT_EQ(array.length(), 0u);
ASSERT_EQ(array.capacity(), 0u);

float data[3] = {};
array.push(data, 0);
array.push_silence(0);
array.push_front_silence(0);

ASSERT_EQ(array.length(), 0u);
ASSERT_EQ(array.capacity(), 0u);
}