Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat(relay): add site eligibility check for Relay with Remote Settings [ci full] #7039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 31, 2025
Merged

feat(relay): add site eligibility check for Relay with Remote Settings [ci full] #7039

merged 1 commit into from
Oct 31, 2025
+470 −0

Conversation

@groovecoder
Copy link
Member

@groovecoder groovecoder commented Oct 27, 2025 •
edited
Loading

Pull Request checklist

  • Breaking changes: This PR follows our breaking change policy
    • This PR follows the breaking change policy:
      • This PR has no breaking API changes
  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Added remote_settings as a dependency (internal workspace crate, already used by other components like Suggest).

@groovecoder groovecoder force-pushed the add-shouldShowRelay-function-MPP-4359 branch 4 times, most recently from 5ddb3a0 to 9d111b1 Compare October 28, 2025 20:36
jonalmeida
jonalmeida reviewed Oct 28, 2025
View reviewed changes
Copy link
Collaborator

@jonalmeida jonalmeida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Gela and I reviewed this together over Zoom and we left a few suggestions below.

The one that stands out, is if we can decouple the relay client from the should_show_relay so that we can perform checks on sites before we have a relay client created.

@groovecoder groovecoder force-pushed the add-shouldShowRelay-function-MPP-4359 branch 5 times, most recently from d7864ac to 9b7ff8d Compare October 29, 2025 18:11
@groovecoder groovecoder changed the title WIP: Add should show relay function mpp 4359 feat(relay): add site eligibility check for Relay with Remote Settings [ci full] Oct 29, 2025
@groovecoder groovecoder force-pushed the add-shouldShowRelay-function-MPP-4359 branch 3 times, most recently from e6bcad7 to 398c0a3 Compare October 29, 2025 19:27
@groovecoder groovecoder marked this pull request as ready for review October 29, 2025 19:27
@groovecoder groovecoder force-pushed the add-shouldShowRelay-function-MPP-4359 branch 2 times, most recently from 3f7b037 to b2012f3 Compare October 30, 2025 14:46
bendk
bendk approved these changes Oct 30, 2025
View reviewed changes
Copy link
Contributor

@bendk bendk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I just had a small suggestion about the error API.

@groovecoder groovecoder force-pushed the add-shouldShowRelay-function-MPP-4359 branch from b2012f3 to c53e5f6 Compare October 30, 2025 20:44
@groovecoder
feat(relay): add site eligibility check for Relay with Remote Settings
9ec8b1e 
Adds Remote Settings integration to enable mobile clients to determine
whether to show Firefox Relay UI based on site allowlist/denylist and
user Relay account status.

- Add new `RelayRemoteSettingsClient` in rs.rs module
  - Fetches allowlist/denylist from Remote Settings collections
  - Implements `should_show_relay()` with three-factor decision logic
  - Includes subdomain-aware domain matching (not PSL-aware)
@groovecoder groovecoder force-pushed the add-shouldShowRelay-function-MPP-4359 branch from c53e5f6 to 9ec8b1e Compare October 30, 2025 21:06
@groovecoder groovecoder added this pull request to the merge queue Oct 31, 2025
Merged via the queue into main with commit 7f873b0 Oct 31, 2025
60 checks passed
@groovecoder groovecoder deleted the add-shouldShowRelay-function-MPP-4359 branch October 31, 2025 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jonalmeida jonalmeida jonalmeida left review comments

@bendk bendk bendk approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@groovecoder @bendk @jonalmeida