Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Oct 23, 2019. It is now read-only.

Comments

[Fixes #147] Unify all actions to detail view#160

Merged
comzeradd merged 1 commit intomozilla:masterfrom
comzeradd:unify
May 13, 2015
Merged

[Fixes #147] Unify all actions to detail view#160
comzeradd merged 1 commit intomozilla:masterfrom
comzeradd:unify

Conversation

@comzeradd
Copy link
Contributor

No description provided.

@comzeradd
Copy link
Contributor Author

@johngian r?

This is a small fix to unify all contribution actions under the detail view. No need to show clone on two different places.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 52.75% when pulling fd43d9a on comzeradd:unify into 39ab2d4 on mozilla:master.

@akatsoulas
Copy link
Contributor

I would argue that it makes sense to have at least clone in the list all contributions view. Having the clone in the 'view all contributions' makes it much faster to clone a contribution than having to inspect each one separately. Moreover, since the clone will basically redirect to the edit page, we make sure that before cloning, our users will introspect each one of the fields.

@johngian
Copy link
Contributor

As I have already said in #147 for me it makes sense to either show all the actions in the list view or none. I tend towards showing all the actions with discrete icons (eg small glyphicons).

@akatsoulas
Copy link
Contributor

I am also in favor of showing all the icons. On the other hand it makes sense to force the users to review the contribution before deleting/upvoting, whereas in clone is just easier and faster to be in the list view. Either way, I am OK with whatever the rest of the team decides. @ppapadeas thoughts?

@comzeradd
Copy link
Contributor Author

I agree with @johngian. I don't like duplication. It should either show all actions or none. I'm leaning towards none. The list view omits many things around a specific contribution, so it makes sense to go on details to determine if that's really the one you want to edit/clone/delete.

@akatsoulas
Copy link
Contributor

But this is not the case for cloning because you basically going to get a redirect to the edit view, so you are forced to inspect the contribution. Hiding cloning in the details, defeats its purpose, that of a fast contribution. Either way, r+ regrading the code.

comzeradd added a commit that referenced this pull request May 13, 2015
[Fixes #147] Unify all actions to detail view
@comzeradd comzeradd merged commit 2c6e75f into mozilla:master May 13, 2015
@comzeradd comzeradd deleted the unify branch May 13, 2015 11:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants