[Fixes #147] Unify all actions to detail view#160
[Fixes #147] Unify all actions to detail view#160comzeradd merged 1 commit intomozilla:masterfrom comzeradd:unify
Conversation
|
@johngian r? This is a small fix to unify all contribution actions under the detail view. No need to show clone on two different places. |
|
I would argue that it makes sense to have at least |
|
As I have already said in #147 for me it makes sense to either show all the actions in the list view or none. I tend towards showing all the actions with discrete icons (eg small glyphicons). |
|
I am also in favor of showing all the icons. On the other hand it makes sense to force the users to review the contribution before deleting/upvoting, whereas in clone is just easier and faster to be in the list view. Either way, I am OK with whatever the rest of the team decides. @ppapadeas thoughts? |
|
I agree with @johngian. I don't like duplication. It should either show all actions or none. I'm leaning towards none. The list view omits many things around a specific contribution, so it makes sense to go on details to determine if that's really the one you want to edit/clone/delete. |
|
But this is not the case for cloning because you basically going to get a redirect to the edit view, so you are forced to inspect the contribution. Hiding cloning in the details, defeats its purpose, that of a fast contribution. Either way, r+ regrading the code. |
[Fixes #147] Unify all actions to detail view
No description provided.