Codestin Search App

calixteman · 2025-02-20T21:35:31Z

No description provided.

external/openjpeg/openjpeg.js

calixteman · 2025-02-20T21:42:41Z

@Snuffleupagus I've two problems with this PR:

gulp lint --fix is taking for ever: it's because of external/openjpeg/openjpeg_nowasm_fallback.js but normally no linter should run on it.
the await import shouldn't be converted into webpack stuff when building for m-c

Could you help me to fix these issues ?

calixteman · 2025-02-20T21:47:27Z

@Snuffleupagus if you see a better way to use the fallback, don't worry to take the ownership of this PR.

Snuffleupagus · 2025-02-20T22:46:48Z

gulp lint --fix is taking for ever: it's because of external/openjpeg/openjpeg_nowasm_fallback.js but normally no linter should run on it.

That folder should already being excluded from linting, given

pdf.js/eslint.config.mjs

Line 37 in 34ef74c

"external/openjpeg/",

Is the problem perhaps rather the web/wasm/ folder, because if so I believe that the following diff should fix that?

diff --git a/eslint.config.mjs b/eslint.config.mjs
index 887e013bb..27893feea 100644
--- a/eslint.config.mjs
+++ b/eslint.config.mjs
@@ -39,6 +39,7 @@ export default [
       "test/tmp/",
       "test/pdfs/",
       "web/locale/",
+      "web/wasm/",
       "**/*~/",
     ],
   },

the await import shouldn't be converted into webpack stuff when building for m-c

Yes, that problem is kind of "expected" unless you explicitly tell Webpack to leave the import alone.
Please refer to the following examples to see how we handle that:

pdf.js/web/app.js

Lines 284 to 287 in 34ef74c

    
           const { PDFBug } = 
        
             typeof PDFJSDev === "undefined" 
        
               ? await import(AppOptions.get("debuggerSrc")) // eslint-disable-line no-unsanitized/method 
        
               : await __non_webpack_import__(AppOptions.get("debuggerSrc"));

pdf.js/web/generic_scripting.js

Lines 39 to 42 in 34ef74c

    
           const sandbox = 
        
             typeof PDFJSDev === "undefined" 
        
               ? import(sandboxBundleSrc) // eslint-disable-line no-unsanitized/method 
        
               : __non_webpack_import__(sandboxBundleSrc);

Snuffleupagus · 2025-02-21T09:08:10Z

Also, how do we (easily) test this?
Could we e.g. have a test in mozilla-central, since I'm assuming that it should be easy (famous last words) to temporarily disable WebAssembly via a preference during testing?

calixteman · 2025-02-21T09:27:25Z

I just added a ref test to check the nowasm path.
Yep it'd make sense to have one too on the m-c side, I'll try to create a pdf with a monochrome jp2 image and check the pixels.

src/core/jpx.js

test/test_manifest.json

Snuffleupagus · 2025-02-21T13:00:39Z

Do we also want to re-init the new #importModuleResolver field in the cleanup method?

pdf.js/src/core/jpx.js

Lines 108 to 110 in e3ea926

    
           static cleanup() { 
        
             this.#modulePromise = null; 
        
           }

Snuffleupagus

Should we also change

pdf.js/src/core/jpx.js

Line 39 in b2a860c

if (!this.#buffer) {

to the following (since this.#buffer may never be set when we fallback to JS-decoding)?

if (!this.#modulePromise) {

src/core/jpx.js

… load (bug 1935076)

Snuffleupagus · 2025-02-21T19:14:03Z

/botio unittest

moz-tools-bot · 2025-02-21T19:14:06Z

From: Bot.io (Linux m4)

Received

Command cmd_unittest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/36e13c35f49e178/output.txt

moz-tools-bot · 2025-02-21T19:14:06Z

From: Bot.io (Windows)

Received

Command cmd_unittest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/a60c9d7055aa88d/output.txt

moz-tools-bot · 2025-02-21T19:16:39Z

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/36e13c35f49e178/output.txt

Total script time: 2.54 mins

Unit Tests: Passed

moz-tools-bot · 2025-02-21T19:21:55Z

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/a60c9d7055aa88d/output.txt

Total script time: 7.80 mins

Unit Tests: Passed

Snuffleupagus · 2025-02-21T19:22:37Z

/botio browsertest

moz-tools-bot · 2025-02-21T19:22:41Z

From: Bot.io (Linux m4)

Received

Command cmd_browsertest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/70f9e28a5045ef7/output.txt

moz-tools-bot · 2025-02-21T19:22:41Z

From: Bot.io (Windows)

Received

Command cmd_browsertest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/61020c03a6af55c/output.txt

moz-tools-bot · 2025-02-21T19:39:52Z

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/70f9e28a5045ef7/output.txt

Total script time: 17.18 mins

Regression tests: Passed

Snuffleupagus

r=me, thank you.

Reminder: When updating mozilla-central, the new JS file needs to be added to https://searchfox.org/mozilla-central/source/toolkit/components/pdfjs/jar.mn

moz-tools-bot · 2025-02-21T19:53:13Z

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/61020c03a6af55c/output.txt

Total script time: 30.53 mins

Regression tests: Passed

Snuffleupagus · 2025-02-21T22:54:00Z

It just occurred to me that the way the wasmUrl option is currently implemented won't work correctly in general, now that we also need to be able to import a fallback JS file on the worker-thread.
This should however not affect mozilla-central and I've already got a WIP patch to improve things, so I'd suggest that we land this PR as-is and improve things in a follow-up.

Snuffleupagus · 2025-02-22T08:34:50Z

/botio makeref

moz-tools-bot · 2025-02-22T08:34:53Z

From: Bot.io (Linux m4)

Received

Command cmd_makeref from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/9efd0b43cf36159/output.txt

moz-tools-bot · 2025-02-22T08:34:53Z

From: Bot.io (Windows)

Received

Command cmd_makeref from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/56b8e129c88d047/output.txt

moz-tools-bot · 2025-02-22T08:51:42Z

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/9efd0b43cf36159/output.txt

Total script time: 16.81 mins

Make references: Passed
Check references: Passed

moz-tools-bot · 2025-02-22T09:05:15Z

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/56b8e129c88d047/output.txt

Total script time: 30.35 mins

Make references: Passed
Check references: Passed

github-advanced-security bot found potential problems Feb 20, 2025

View reviewed changes

calixteman force-pushed the bug1935076_part2 branch from 12ae19e to c88801c Compare February 20, 2025 21:40

Snuffleupagus added image-jpx image-conversion labels Feb 20, 2025

calixteman force-pushed the bug1935076_part2 branch from c88801c to 84e8179 Compare February 21, 2025 09:30

calixteman marked this pull request as ready for review February 21, 2025 09:30

Snuffleupagus reviewed Feb 21, 2025

View reviewed changes

src/core/jpx.js Outdated Show resolved Hide resolved

test/test_manifest.json Outdated Show resolved Hide resolved

calixteman force-pushed the bug1935076_part2 branch from 84e8179 to b5265d2 Compare February 21, 2025 12:45

calixteman force-pushed the bug1935076_part2 branch from b5265d2 to b2a860c Compare February 21, 2025 15:28

Snuffleupagus reviewed Feb 21, 2025

View reviewed changes

src/core/jpx.js Outdated Show resolved Hide resolved

Provide a js fallback when the wasm version of openjpeg is failing to…

36e4f5c

… load (bug 1935076)

calixteman force-pushed the bug1935076_part2 branch from b2a860c to 36e4f5c Compare February 21, 2025 18:03

Snuffleupagus approved these changes Feb 21, 2025

View reviewed changes

Snuffleupagus added the release-blocker Blocker for the upcoming release label Feb 21, 2025

Snuffleupagus merged commit 6d3bb47 into mozilla:master Feb 22, 2025
9 checks passed

Snuffleupagus mentioned this pull request Feb 22, 2025

[api-minor] Re-factor how the useWorkerFetch option is used internally #19537

Merged

Snuffleupagus mentioned this pull request Mar 7, 2025

Version 5 release checklist #19536

Closed

4 tasks

Snuffleupagus linked an issue Apr 8, 2025 that may be closed by this pull request

[Bug]: PDF not renderable due to CSP not allowing WASM since PDFJS4 - CompileError: WebAssembly.Module(): Refused to compile or instantiate WebAssembly module #18457

Closed

Snuffleupagus mentioned this pull request Feb 8, 2026

Avoid branching in convertBlackAndWhiteToRGBA #20638

Merged

Comments

Conversation

calixteman commented Feb 20, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

calixteman commented Feb 20, 2025

Uh oh!

calixteman commented Feb 20, 2025

Uh oh!

Snuffleupagus commented Feb 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Snuffleupagus commented Feb 21, 2025

Uh oh!

calixteman commented Feb 21, 2025

Uh oh!

Uh oh!

Uh oh!

Snuffleupagus commented Feb 21, 2025

Uh oh!

Snuffleupagus left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Snuffleupagus commented Feb 21, 2025

Uh oh!

moz-tools-bot commented Feb 21, 2025

From: Bot.io (Linux m4)

Received

Uh oh!

moz-tools-bot commented Feb 21, 2025

From: Bot.io (Windows)

Received

Uh oh!

moz-tools-bot commented Feb 21, 2025

From: Bot.io (Linux m4)

Success

Uh oh!

moz-tools-bot commented Feb 21, 2025

From: Bot.io (Windows)

Success

Uh oh!

Snuffleupagus commented Feb 21, 2025

Uh oh!

moz-tools-bot commented Feb 21, 2025

From: Bot.io (Linux m4)

Received

Uh oh!

moz-tools-bot commented Feb 21, 2025

From: Bot.io (Windows)

Received

Uh oh!

moz-tools-bot commented Feb 21, 2025

From: Bot.io (Linux m4)

Success

Uh oh!

Snuffleupagus left a comment

Choose a reason for hiding this comment

Uh oh!

moz-tools-bot commented Feb 21, 2025

From: Bot.io (Windows)

Success

Uh oh!

Snuffleupagus commented Feb 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Snuffleupagus commented Feb 22, 2025

Uh oh!

moz-tools-bot commented Feb 22, 2025

From: Bot.io (Linux m4)

Snuffleupagus commented Feb 20, 2025 •

edited

Loading

Snuffleupagus commented Feb 21, 2025 •

edited

Loading