Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@calixteman
Copy link
Contributor

No description provided.

@calixteman calixteman added editor To Review For PRs to review after they've been merged (for example when reviewers are off). labels Sep 26, 2025
@calixteman
Copy link
Contributor Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/4f41653c39b9af0/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/753169d520b4806/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/4f41653c39b9af0/output.txt

Total script time: 19.21 mins

  • Integration Tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Success

Full output at http://54.193.163.58:8877/753169d520b4806/output.txt

Total script time: 44.28 mins

  • Integration Tests: Passed

@calixteman calixteman merged commit 28fb4f0 into mozilla:master Sep 26, 2025
7 checks passed
@calixteman calixteman deleted the bug1990762 branch September 26, 2025 09:09
@timvandermeij timvandermeij removed their request for review October 4, 2025 12:36
Copy link
Contributor

@timvandermeij timvandermeij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, with one comment.

const x = rect.x + rect.width / 2;
const y = rect.y + rect.height / 2;
await page.mouse.click(x, y, { count: 2, delay: 100 });
await page.waitForSelector(getEditorSelector(0));
Copy link
Contributor

@timvandermeij timvandermeij Oct 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aren't we potentially waiting for the wrong selector here, given that where it's used we seem to be interested in editor selector 9 as being the highlight editor?

It may also be useful to use a helper like this in more places.

@timvandermeij timvandermeij removed the To Review For PRs to review after they've been merged (for example when reviewers are off). label Oct 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants