Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Editor] Add a fake annotation (in the annotation layer) associated with an editor in order to be able to show the comment button (bug 1989420) #20321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
calixteman merged 1 commit into from
Oct 1, 2025
Merged

[Editor] Add a fake annotation (in the annotation layer) associated with an editor in order to be able to show the comment button (bug 1989420) #20321

calixteman merged 1 commit into from
Oct 1, 2025

Conversation

@calixteman
Copy link
Contributor

@calixteman calixteman commented Sep 30, 2025

No description provided.

@calixteman calixteman added editor To Review For PRs to review after they've been merged (for example when reviewers are off). labels Sep 30, 2025
@calixteman
Copy link
Contributor Author

calixteman commented Sep 30, 2025

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Sep 30, 2025

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/02c40552980fbe7/output.txt

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Sep 30, 2025

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/6dae4e6a9a21485/output.txt

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Sep 30, 2025

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/02c40552980fbe7/output.txt

Total script time: 19.35 mins

  • Integration Tests: Passed

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Sep 30, 2025

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/6dae4e6a9a21485/output.txt

Total script time: 42.30 mins

  • Integration Tests: FAILED

@calixteman
Copy link
Contributor Author

calixteman commented Sep 30, 2025

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Sep 30, 2025

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/2e8c6ae13c0bc93/output.txt

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Sep 30, 2025

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/aba7f12fae42da1/output.txt

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Sep 30, 2025

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/2e8c6ae13c0bc93/output.txt

Total script time: 19.50 mins

  • Integration Tests: Passed

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Sep 30, 2025

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/aba7f12fae42da1/output.txt

Total script time: 42.81 mins

  • Integration Tests: FAILED

@calixteman
Copy link
Contributor Author

calixteman commented Sep 30, 2025

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Sep 30, 2025

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/30c16c8c1e87e4e/output.txt

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Sep 30, 2025

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/a5ccfe954131242/output.txt

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Sep 30, 2025

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/30c16c8c1e87e4e/output.txt

Total script time: 19.40 mins

  • Integration Tests: Passed

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Sep 30, 2025

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/a5ccfe954131242/output.txt

Total script time: 44.08 mins

  • Integration Tests: FAILED

@calixteman
Copy link
Contributor Author

calixteman commented Oct 1, 2025

/botio-windows integrationtest

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Oct 1, 2025

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/4bf3f824a4541fa/output.txt

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Oct 1, 2025

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/4bf3f824a4541fa/output.txt

Total script time: 3.24 mins

  • Integration Tests: FAILED

@calixteman
[Editor] Add a fake annotation (in the annotation layer) associated w…
12066af 
…ith an editor in order to be able to show the comment button (bug 1989420)
@calixteman
Copy link
Contributor Author

calixteman commented Oct 1, 2025

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Oct 1, 2025

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/75cc38ff20e93db/output.txt

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Oct 1, 2025

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/a3d50b3292ee502/output.txt

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Oct 1, 2025

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/a3d50b3292ee502/output.txt

Total script time: 19.31 mins

  • Integration Tests: Passed

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Oct 1, 2025

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/75cc38ff20e93db/output.txt

Total script time: 43.40 mins

  • Integration Tests: Passed

@calixteman calixteman merged commit d18289b into mozilla:master Oct 1, 2025
9 checks passed
@calixteman calixteman deleted the bug1989420 branch October 1, 2025 11:40
@markmatney
Copy link

markmatney commented Oct 2, 2025

This appears to have caused a regression; npx gulp makeref now hangs at the test for issue13915 and fails all subsequent tests. In the console output:

JavaScript error: http://127.0.0.1:12345/test/driver.js, line 295: Error: Rasterize.annotationLayer: "can't access property "getDestinationHash", this.linkService is null".

@timvandermeij timvandermeij removed their request for review October 4, 2025 12:27
timvandermeij
timvandermeij reviewed Oct 5, 2025
View reviewed changes
src/display/annotation_layer.js
return this.#editableAnnotations.get(id);
}

addFakeAnnotation(editor) {
Copy link
Contributor

@timvandermeij timvandermeij Oct 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to have a docstring or other documentation that explains the purpose of the fake annotation (i.e., what do we need it for?).

@timvandermeij
Copy link
Contributor

timvandermeij commented Oct 5, 2025

Looks good to me, with one comment.

@timvandermeij timvandermeij removed the To Review For PRs to review after they've been merged (for example when reviewers are off). label Oct 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@timvandermeij timvandermeij timvandermeij left review comments

Assignees

No one assigned

Labels

editor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@calixteman @moz-tools-bot @markmatney @timvandermeij