Keybinding fixes #409
Merged
Keybinding fixes #409
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Its className() is QLineEdit so it was getting saved by classFetcher. This fixes a crash (made easier to reproduce by 318d347) when trying to restore its value after we double clicked in a QKeySequenceEdit then clicked Cancel, after first closing Options with OK.
This ensures that key shortcuts don't get captured by the key editor once we close Options. Follow-up to 318d347.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Its className() is QLineEdit so it was getting saved by classFetcher.
This fixes a crash (made easier to reproduce by 318d347) when trying to restore its value after we double clicked in a QKeySequenceEdit then clicked Cancel, after first closing Options with OK.
This ensures that key shortcuts don't get captured by the key editor once we close Options.
Follow-up to 318d347.