Fix early finish #167
Merged
Fix early finish #167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fake a file end event when a file does not properly initialize. Consider the case where a stream is opened but fails to properly initialize such as the url https://chiru.no:8000/stream.mp3. In these scenarios libmpv would finish playback before it starts, and the player would be stuck in the Buffering state. We need to progress to the next file in the playlist. We need to get out of the Buffering state when there is no file after us in the playlist. So send a stopped state event and jump to the code that handles an end of file event. This mimics the behviour of mpc-hc from my tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fake a file end event when a file does not properly initialize.
Consider the case where a stream is opened but fails to properly initialize such as the url https://chiru.no:8000/stream.mp3. In these scenarios libmpv would finish playback before it starts, and the player would be stuck in the Buffering state. We need to progress to the next file in the playlist. We need to get out of the Buffering state when there is no file after us in the playlist. So send a stopped state event and jump to the code that handles an end of file event. This mimics the behviour of mpc-hc from my tests.