Replace Fine (seek) step by Large step, Time step by Normal step #196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Users probably need a large seek step more than a finer seek step (than normal). If users really want a finer seek step and we can find a way to fit a third option, we could add it later. Fixes mpc-qt#117
Reorder actions so that seek actions aren't at the bottom in keys settings. Reorder seek and frame step commands so that back comes before next (like for most other commands).
Reorder previous and next subtitle commands so that their order matches the order of all other commands (previous at the top, next at the bottom).
|
LGTM. Some users may need to reset their shortcut keys but that's what happens when you migrate between versions. |
|
It may be a good idea to mention in the changelog that this is a breaking change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users probably need a large seek step more than a finer seek step (than normal).
If users really want a finer seek step and we can find a way to fit a third option, we could add it later.
Fixes Feature Request: Custom jump distances #117
Reorder actions so that seek actions aren't at the bottom in keys
settings.
Reorder seek and frame step commands so that back comes before next
(like for most other commands).
Reorder previous and next subtitle commands so that their order matches
the order of all other commands (previous at the top, next at the
bottom).