Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add a disabled state for white icons (dark fallback theme) #254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 10, 2024
Merged

Add a disabled state for white icons (dark fallback theme) #254

merged 2 commits into from
Nov 10, 2024

Conversation

@tbertels
Copy link
Member

@tbertels tbertels commented Nov 10, 2024 •
edited
Loading

  • Use more verbose names for folderMode, fallbackFolder and customFolder
  • Add a disabled state pixmap for white icons in fallback theme
    Qt doesn't provide a useful disabled mode for white icons (dark theme), they just stay white.

Before:

Copie d'écran_20241110_125327

After:

Copie d'écran_20241110_125223

@tbertels
Use more verbose names for folderMode, fallbackFolder and customFolder
bd8eec3
@tbertels
Add a disabled state pixmap for white icons in fallback theme
1e3bdd1 
Qt doesn't provide a useful disabled mode for white icons (dark theme),
they just stay white.
@tbertels tbertels changed the title Add a disabled state for white icons (dark theme) Add a disabled state for white icons (dark fallback theme) Nov 10, 2024
@cmdrkotori cmdrkotori merged commit dbc0e6a into mpc-qt:master Nov 10, 2024
2 checks passed
@tbertels
Copy link
Member Author

We may want to backport this to release.

@cmdrkotori
Copy link
Member

Commits bd8eec3 and 1e3bdd1 have been backported to release/24.12

@tbertels tbertels deleted the disable_icons branch November 11, 2024 09:10
@tbertels tbertels added the backported This pull request has been backported to the latest release label Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

backported This pull request has been backported to the latest release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tbertels @cmdrkotori