Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@cmdrkotori
Copy link
Member

No description provided.

@tbertels
Copy link
Member

Nice!

The icons don't seem to be centered in their frame.
This was already the case with the old ones, but I'm thinking it wouldn't hurt to center them while you're at it.

@tbertels
Copy link
Member

tbertels commented Dec 16, 2024

And shouldn't they be slightly bigger?
The old ones represented the subtitles but the new ones are supposed to show a screen, and they look smaller than the speaker icon next to it.

The icons don't seem to be centered in their frame.

By the way, we probably want to revisit all the icons to center them some time in the future.

@cmdrkotori
Copy link
Member Author

The icons don't seem to be centered in their frame.

Yeah I just checked kde's guidelines for icons and they have everything centered.

Why did this happen? Back in the day when I was writing Win32 apps, small icons in toolbars typically had their bottom-most and rightmost pixels blank, so everything was up and to the left slightly.

And shouldn't they be slightly bigger?

Possibly yes. If the margins don't have to be as big, the visible part of the icon can be bigger. I checked the icons in /usr/share/icons/breeze/actions/16, and they seem to have 1px (sometimes) or 2px (most) margins all around the sides. It seems I've used 2+3 pixel margins so far.

By the way, we probably want to revisit all the icons to center them some time in the future.

This will probably take anywhere up to a few hours as all the icons have to be edited. I might get to it sometime in the coming week.

@tbertels
Copy link
Member

tbertels commented Dec 16, 2024

Why did this happen? Back in the day when I was writing Win32 apps, small icons in toolbars typically had their bottom-most and rightmost pixels blank, so everything was up and to the left slightly.

Wasn't it because the buttons click animation used to be them being pushed down? And that animation moved the icon down and to the right, so there had to be some free space.

Possibly yes. If the margins don't have to be as big, the visible part of the icon can be bigger. I checked the icons in /usr/share/icons/breeze/actions/16, and they seem to have 1px (sometimes) or 2px (most) margins all around the sides. It seems I've used 2+3 pixel margins so far.

I was talking specifically about these new subtitles icons which seem smaller than the other ones.
But I guess it can be done later if needed.

@tbertels tbertels merged commit 9477f7e into mpc-qt:master Dec 16, 2024
4 checks passed
@tbertels tbertels added the follow up There are further actions suggested in the discussion label Dec 16, 2024
@tbertels tbertels removed the follow up There are further actions suggested in the discussion label Dec 20, 2024
@cmdrkotori cmdrkotori deleted the subtitles_fallback_icon branch July 29, 2025 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants