Fix playlist hidden on start #397
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise, the playlist is always hidden on start. The PlaylistWindow is automatically being closed with the MainWindow. Because of this, PlaylistWindow::toggleViewAction is getting called and calls MainWindow::setPlaylistVisibleState. There, actionViewHidePlaylist gets unchecked. And since ba8d01c, we save settings after (instead of before) the playlist has been automatically closed. This means that actionViewHidePlaylist is already unchecked when we save its state. By not unchecking it when the window is closing, we prevent that. Note: 5c778bf doesn't have any role in this regression. Note 2: MainWindow::setPlaylistVisibleState seems to get called twice at the same time when the auto zoom is enabled. That's probably why this bug wasn't reproduceable with auto zoom enabled. Fixes mpc-qt#392.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, the playlist is always hidden on start.
The PlaylistWindow is automatically being closed with the MainWindow.
Because of this, PlaylistWindow::toggleViewAction is getting called and calls MainWindow::setPlaylistVisibleState.
There, actionViewHidePlaylist gets unchecked.
And since ba8d01c, we save settings after (instead of before) the playlist has been automatically closed.
This means that actionViewHidePlaylist is already unchecked when we save its state.
By not unchecking it when the window is closing, we prevent that.
Note: 5c778bf doesn't have any role in this regression.
Note 2: MainWindow::setPlaylistVisibleState seems to get called twice at the same time when the auto zoom is enabled. That's probably why this bug wasn't reproduceable with auto zoom enabled.
Fixes Playlist window gets hidden on start if auto zoom is disabled #392.